feat: Implements TLS in Litmus backend #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
backend/lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
backend/lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
backend/lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
backend/lib/charms/tls_certificates_interface/v4/tls_certificates.py
Dismissed
Show dismissed
Hide dismissed
PietroPasotti
requested changes
Sep 9, 2025
Collaborator
PietroPasotti
left a comment
PietroPasotti
left a comment
There was a problem hiding this comment.
A few points to be addressed, mainly about encapsulation in the newly added TLS class.
LMK if you need clarification.
PietroPasotti
requested changes
Sep 9, 2025
Collaborator
PietroPasotti
left a comment
PietroPasotti
left a comment
There was a problem hiding this comment.
we're getting there, but I think the Tls object's interface can be simplified further.
A couple of nits on the testing code as well.
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Co-authored-by: PietroPasotti <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Gmerold
force-pushed
the
TAP-718-tls-in-backend
branch
from
6bdad37 to
2e77a98
Compare
Signed-off-by: Bartlomiej Gmerek <[email protected]>
PietroPasotti
approved these changes
Sep 12, 2025
Collaborator
|
the integration test failure you're seeing is also regularly happening on my branch and is probably unrelated to our changes. I think this indicates that the frontend that's released on 2/edge is broken. Something for @mmkay to look into when he's back I reckon, I think we should merge this on red if necessary. |
Co-authored-by: PietroPasotti <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Signed-off-by: Bartlomiej Gmerek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements TLS support in the Litmus Backend charm as specified in TAP-718.
TLS certificates are handled through the
tls-certificatescharm interface.TLS is optional and enabled automatically upon
tls-certificatesrelation creation.Fixes #23
NOTE: local-backend itests are expected to fail at this point.