Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs to metadata for gatekeeper #6

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

Thanhphan1147
Copy link
Collaborator

Gatekeeper is using the main branch to fetch the charmhub url to the charm's doc set. This cause CI in PRs to fail because no PR has been merged to update this field

Applicable spec:

Overview

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

Gatekeeper is using the `main` branch to fetch the charmhub url to the charm's doc set. This cause CI in PRs to fail because no PR has been merged to update this field
@Thanhphan1147 Thanhphan1147 added the trivial This is a trivial PR label Jan 8, 2024
@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner January 8, 2024 17:19
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 34 files.

Valid Invalid Ignored Fixed
0 10 24 0
Click to see the invalid file list
  • charmcraft.yaml
  • config.yaml
  • generate-src-docs.sh
  • metadata.yaml
  • src/charm.py
  • tests/conftest.py
  • tests/integration/init.py
  • tests/integration/test_charm.py
  • tests/unit/init.py
  • tests/unit/test_base.py

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Test coverage for db787e0

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      30      0      4      0   100%
----------------------------------------------------------
TOTAL             30      0      4      0   100%

Static code analysis report

Run started:2024-01-08 17:32:21.457768

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 149
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@Thanhphan1147 Thanhphan1147 merged commit 46033f2 into main Jan 8, 2024
19 checks passed
@Thanhphan1147 Thanhphan1147 deleted the update_metadata branch January 8, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial This is a trivial PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants