Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump package version to 1.0.10 #32

Merged
merged 1 commit into from
Apr 24, 2024
Merged

bump package version to 1.0.10 #32

merged 1 commit into from
Apr 24, 2024

Conversation

Thanhphan1147
Copy link
Collaborator

@Thanhphan1147 Thanhphan1147 commented Apr 19, 2024

bump the package version to 1.0.10, increasing service restart timeout to 5s

Overview

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner April 19, 2024 18:13
@Thanhphan1147 Thanhphan1147 marked this pull request as draft April 19, 2024 18:13
Copy link
Contributor

Test coverage for d2ed5b1

Name                    Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------
src/agent_observer.py      42      0      4      0   100%
src/charm.py               63      0     10      0   100%
src/charm_state.py         59      4      8      1    93%   114, 172-174
src/service.py             99      5     14      5    91%   94-96, 108->120, 135, 167, 204->208, 206->204
-------------------------------------------------------------------
TOTAL                     263      9     36      6    95%

Static code analysis report

Run started:2024-04-19 18:15:29.277458

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1140
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@Thanhphan1147 Thanhphan1147 marked this pull request as ready for review April 23, 2024 12:44
@Thanhphan1147 Thanhphan1147 added the trivial This is a trivial PR label Apr 24, 2024
@Thanhphan1147 Thanhphan1147 merged commit 349ba33 into main Apr 24, 2024
20 checks passed
@Thanhphan1147 Thanhphan1147 deleted the bump-package-version branch April 24, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Libraries: OK trivial This is a trivial PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants