Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking changes guidelines #79

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

arturo-seijas
Copy link
Contributor

No description provided.

@arturo-seijas arturo-seijas requested a review from a team as a code owner July 3, 2024 09:34
Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, how about the following scenario:

  1. configuration experimental-config-option on revision 1
  2. configuration alternative-config-option option on revision 2 w/ depreation of 1.
  3. should here be a different track if 1 is deprecated?
    LGTM!

@arturo-seijas
Copy link
Contributor Author

Out of curiosity, how about the following scenario:

  1. configuration experimental-config-option on revision 1
  2. configuration alternative-config-option option on revision 2 w/ depreation of 1.
  3. should here be a different track if 1 is deprecated?
    LGTM!

Not if it's not officially supported. Experimental actually means it is not guaranteed to be supported in the future, as I understand it

@arturo-seijas arturo-seijas merged commit b162d9c into main Jul 3, 2024
1 check passed
@arturo-seijas arturo-seijas deleted the define-breaking-change branch July 3, 2024 11:41

Charms published to tracks different from `latest` should guarantee seemlessly
upgrades between revisions, that is, revisions should not introduce breaking
changes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps include a link here to the definition of a breaking change above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants