Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor the charm #165

Merged
merged 11 commits into from
Aug 27, 2024
Merged

refactor: refactor the charm #165

merged 11 commits into from
Aug 27, 2024

Conversation

wood-push-melon
Copy link
Contributor

@wood-push-melon wood-push-melon commented Jul 22, 2024 •
edited
Loading

This pull request refactors the whole hydra-operator charm based on the specific idea.

Note:

  • did not use the CollectStatusEvent because there are several places where several pre-check conditions happen (set the status to some status if the condition fails).

@wood-push-melon wood-push-melon changed the title refactor: refactor command line WIP refactor: refactor command line Jul 22, 2024
@wood-push-melon wood-push-melon changed the title WIP refactor: refactor command line WIP refactor: refactor the charm Aug 9, 2024
@wood-push-melon wood-push-melon marked this pull request as ready for review August 14, 2024 00:17
@wood-push-melon wood-push-melon requested a review from a team as a code owner August 14, 2024 00:17
@wood-push-melon wood-push-melon changed the title WIP refactor: refactor the charm refactor: refactor the charm Aug 14, 2024
@shipperizer
Copy link
Contributor

shipperizer commented Aug 15, 2024 •
edited
Loading

@wood-push-melon we should drop the chore: merge main commits and do a proper rebase

have a look at https://github.com/canonical/hydra-operator/compare/rebase/IAM-958?expand=1

natalian98
natalian98 previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@natalian98 natalian98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Could we have a test for upgrading the charm? See example

@natalian98 natalian98 requested a review from a team August 20, 2024 09:47
@wood-push-melon
Copy link
Contributor Author

Looks good to me.

Could we have a test for upgrading the charm? See example

Thanks. Will add the test for the charm upgrade.

@natalian98 natalian98 requested a review from a team August 23, 2024 13:35
@wood-push-melon wood-push-melon merged commit f66ced3 into main Aug 27, 2024
3 checks passed
@wood-push-melon wood-push-melon deleted the IAM-958 branch August 27, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarcoMasile BarcoMasile BarcoMasile left review comments

@shipperizer shipperizer shipperizer approved these changes

@natalian98 natalian98 natalian98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wood-push-melon @shipperizer @BarcoMasile @natalian98