Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate versioning scheme for the client cargo and Debian packages #261

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

nadzyah
Copy link
Collaborator

@nadzyah nadzyah commented Dec 10, 2024

The PR resolves C3-957.
It adds the automation pipeline to ensure that the Debian changelog main version (before the ~ sign) and cargo version for both hwlib and hwctl packages are the same and match the latest v*.*.* version.

Since the server charm publishing workflow also creates tags, it was adjusted to use a tag_prefix to make the charm releases easily distinguishable from the client tags in the repo.

@nadzyah nadzyah force-pushed the automated-versioning-scheme branch from 731374d to 94c6074 Compare December 10, 2024 15:33
@nadzyah nadzyah marked this pull request as draft December 10, 2024 16:23
@nadzyah nadzyah force-pushed the automated-versioning-scheme branch 3 times, most recently from acee3ff to 48801d3 Compare December 11, 2024 13:35
Now charm releases are easily distinguishable from the other
releases / tags in the repo.
@nadzyah nadzyah force-pushed the automated-versioning-scheme branch from 48801d3 to d048965 Compare December 11, 2024 15:24
@nadzyah nadzyah marked this pull request as ready for review December 11, 2024 15:25
@nadzyah nadzyah requested a review from plars December 11, 2024 15:25
Copy link
Contributor

@plars plars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small question

client/README.md Show resolved Hide resolved
Copy link

@boukeas boukeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I have just one question, something that might require a rephrasing or clarification in the documentation.

.github/workflows/test_hwlib_debian_build.yaml Outdated Show resolved Hide resolved
Comment on lines +155 to +156
If the new version includes changes to the MAJOR, MINOR, or PATCH
version numbers, update the version fields in the following files:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am little confused. Is there any chance there would be a release that doesn't change at least one of these numbers?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can release an update to PPA with the ppa prefix, but if you do releases to Ubuntu main, you should increment the version number

@nadzyah nadzyah force-pushed the automated-versioning-scheme branch from d048965 to 6edd421 Compare December 16, 2024 14:13
@nadzyah nadzyah merged commit 80c8025 into main Dec 16, 2024
5 checks passed
@nadzyah nadzyah deleted the automated-versioning-scheme branch December 16, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants