-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate versioning scheme for the client cargo and Debian packages #261
Conversation
731374d
to
94c6074
Compare
acee3ff
to
48801d3
Compare
Now charm releases are easily distinguishable from the other releases / tags in the repo.
48801d3
to
d048965
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I have just one question, something that might require a rephrasing or clarification in the documentation.
If the new version includes changes to the MAJOR, MINOR, or PATCH | ||
version numbers, update the version fields in the following files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am little confused. Is there any chance there would be a release that doesn't change at least one of these numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can release an update to PPA with the ppa
prefix, but if you do releases to Ubuntu main, you should increment the version number
d048965
to
6edd421
Compare
The PR resolves C3-957.
It adds the automation pipeline to ensure that the Debian changelog main version (before the
~
sign) and cargo version for bothhwlib
andhwctl
packages are the same and match the latestv*.*.*
version.Since the server charm publishing workflow also creates tags, it was adjusted to use a tag_prefix to make the charm releases easily distinguishable from the client tags in the repo.