Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(go): Cleanup some job steps #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

3v1n0
Copy link
Contributor

@3v1n0 3v1n0 commented Feb 23, 2024

Cleanup the code and expose variables when required, as discussed in #25

It could have been set at more global level, but it's not relevant yet.
It's the shellcheck suggested way to find out whether a command is
there, and just nicer to use as it doesn't imply launching anything else.
Copy link
Collaborator

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess after #25, please provide a link of a successful github action run with those changes.

@3v1n0
Copy link
Contributor Author

3v1n0 commented Feb 25, 2024

I guess after #25, please provide a link of a successful github action run with those changes.

I feel it would be better and more maintainable to add some example jobs to this repo to test the actions on each MR, so I'd rather prefer doing that once I've time for.

@didrocks
Copy link
Collaborator

I’m not going to merge something that is impacting a lot of project without having a link though :p Even if the changes looks trivial, as the previous PR failure, I don’t think we should trust not spotting any typos.

@3v1n0
Copy link
Contributor Author

3v1n0 commented Feb 26, 2024

I’m not going to merge something that is impacting a lot of project without having a link though :p Even if the changes looks trivial, as the previous PR failure, I don’t think we should trust not spotting any typos.

Indeed, I agree with that, reason why I think we should first focus on having example projects to test against at each PR as I did on #28 before merging anything anywhere :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants