[DPE-3373] Add servlet filters to Charmed Spark image #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deusebio
previously approved these changes
Mar 18, 2024
There was a problem hiding this comment.
LGTM. The only remark I have is that we are starting to have a number of jars, maybe it would be nice to have a bit more integrated handling, like specifying the extra jars in a list (with their sha), as it is done here
If it is reasonably simple (max 15-30min), we can address this here, if @welpaolo does not mind. It is not a strong point so I'm going to approve anyway
deusebio
previously approved these changes
Mar 19, 2024
theoctober19th
previously approved these changes
Mar 20, 2024
theoctober19th
approved these changes
Mar 20, 2024
deusebio
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.