Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5350][DPE-5416] Add sbom generation in CI #107

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Conversation

welpaolo
Copy link
Collaborator

@welpaolo welpaolo commented Sep 5, 2024

This PR address the generation of SBOM for charmed-spark-rock image.

When the PR will be approved this changes will be backported in 3.5-22.04/edge

Copy link
Member

@theoctober19th theoctober19th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Maybe just change the description to also include the ticket of the fix for the minio problem. I believe Bikalpa created one, I would just use it to have a reference in the comit since it is actually a substantial part of this PR

@welpaolo welpaolo changed the title [DPE-5350] Add sbom generation in CI [DPE-5350][DPE-5416] Add sbom generation in CI Sep 17, 2024
@welpaolo welpaolo merged commit b8cabda into 3.4-22.04/edge Sep 17, 2024
17 checks passed
@welpaolo welpaolo deleted the dpe-5350-3.4 branch September 17, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants