Drop custom tigera operator patches #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Tigera operator expects the ImageSet specs to contain the original image names, not the custom ones. We'll drop our custom patches and update the integration tests accordingly. We need to remove "calico-ctl" from the image spec as the Tigera operator does not expect it and is going to throw an error. While at it, we'll avoid using the "match" expression since it's unsupported on 22.04.
petrutlucian94
force-pushed
the
lpetrut/drop_custom_patches
branch
from
93997df to
edb1385
Compare
|
I've opened an upstream PR to improve the ImageSet documentation: tigera/operator#3635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tigera operator expects the ImageSet specs to contain the original image names, not the custom ones. We'll drop our custom patches and update the integration tests accordingly.
We need to remove "calico-ctl" from the image spec as the Tigera operator does not expect it and is going to throw an error.
While at it, we'll avoid using the "match" expression since it's unsupported on 22.04.