Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions to control the new workload #54

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

nrobinaubertin
Copy link
Collaborator

@nrobinaubertin nrobinaubertin commented Oct 9, 2024

Overview

Checklist

@nrobinaubertin nrobinaubertin marked this pull request as ready for review October 10, 2024 10:03
@nrobinaubertin nrobinaubertin requested a review from a team as a code owner October 10, 2024 10:03
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
config.yaml Show resolved Hide resolved
@amandahla
Copy link

Nice PR!

Some points:

  • I missed unit tests and failure tests
  • For this one or a further PR: documentation on how to use charmed-bind-snap

@nrobinaubertin
Copy link
Collaborator Author

* I missed unit tests and failure tests

There's not a a lot of added logic in the charm for now, everything is mostly handled by the snap who has its own tests.
New tests will come when actually using these ACLs in the next PR

* For this one or a further PR: documentation on how to use charmed-bind-snap

This will be done in the next cycle for sure

amandahla
amandahla previously approved these changes Oct 15, 2024
Copy link

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Test coverage for aa554fa

Name                               Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------------
lib/charms/bind/v0/dns_record.py     231     10     22      0    96%   324-329, 637-644
src/actions_mixin.py                  19     19      0      0     0%   9-92
src/bind.py                          140    140     32      0     0%   6-390
src/charm.py                         169    169     36      0     0%   7-341
src/constants.py                      14     14      0      0     0%   6-71
src/dns_data.py                       72     14     38      0    80%   38-51
src/events.py                          2      2      0      0     0%   7-10
src/exceptions.py                      3      3      0      0     0%   7-16
src/models.py                         33      5      4      0    81%   60-66, 111
------------------------------------------------------------------------------
TOTAL                                683    376    132      0    44%

Static code analysis report

Run started:2024-10-15 19:57:54.544361

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2721
  Total lines skipped (#nosec): 9
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants