fix(DRM): keys missing in the license marked as decipherable #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So as we said (I'm just writing it here so we don't forget) maybe the best way would be to notice after the We could potentially do that by linking a |
Florent-Bouisset
force-pushed
the
fix/issue-1427-missingKeysInLicense
branch
from
8dd39b3
to
5a2a115
Compare
peaBerberian
added
the
Priority: 2 (Medium)
…ing in license. This affect the mode "singleLicensePer": "init-data". In this mode a key that was expected to be in the lissing but that is missing should be considered as non usable. This should improve the behavior when the player is configured as "singleLicensePer": "init-data", and the license server provide proactively licenses for representation we did not intended to play right now.
Florent-Bouisset
force-pushed
the
fix/issue-1427-missingKeysInLicense
branch
from
5a2a115
to
fa443d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, even if certain keys were missing from a license, the representation was still marked as decipherable. This commit change this behavior to require explicit inclusion of keys in the license for the representation to be considered decipherable.
Relates to #1427