Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(crdb): remove support for cockroach db from code base #4462

Merged
merged 1 commit into from
Jul 24, 2024
Merged

chore(crdb): remove support for cockroach db from code base #4462

merged 1 commit into from
Jul 24, 2024

Conversation

joaquinfelici
Copy link
Contributor

Related to #4460

@joaquinfelici joaquinfelici added ci:all-db Runs the builds for all databases. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:migration Runs the process instance migration builds. ci:rolling-update Runs the rolling update builds. labels Jun 27, 2024
@joaquinfelici joaquinfelici self-assigned this Jun 27, 2024
@joaquinfelici joaquinfelici force-pushed the 4460-RemoveCrdbSupport branch 2 times, most recently from 8f1e4cd to b99ee3a Compare June 28, 2024 12:42
@joaquinfelici joaquinfelici marked this pull request as ready for review July 2, 2024 13:49
@joaquinfelici joaquinfelici mentioned this pull request Jul 2, 2024
Closed
psavidis
psavidis approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@psavidis psavidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @joaquinfelici 👍

  • Went through the files one by one; all cockroachdb specific code and references are removed.
  • Searched through all the monorepo for crdb, cockroachdb instances. Couldn't find any.
      • There is only CrdbTransactionRetryException which to my understanding should be part of the .clirr-jenkins-ignore.xml file.

🔧 There is only one last reference i can find in the PR labels file. Perhaps we'd like to get rid of that as well?

Other than that, the tests passed and everything else looks good to me 👍

PS: Happy to see all this code and conditionals in the tests removed.

@joaquinfelici
Copy link
Contributor Author

@psavidis Thanks for the review.
As discussed, not sure about removing the label, our wiki mentions that labels should be kept consistent between repos.
I'll merge this as is and confirm this in the meantime. If needed, I'll remove this in a new PR.

@joaquinfelici joaquinfelici merged commit 23c7ef0 into master Jul 24, 2024
4 checks passed
@joaquinfelici joaquinfelici deleted the 4460-RemoveCrdbSupport branch July 24, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psavidis psavidis psavidis approved these changes

Assignees

@joaquinfelici joaquinfelici

Labels
ci:all-db Runs the builds for all databases. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:migration Runs the process instance migration builds. ci:rolling-update Runs the rolling update builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joaquinfelici @psavidis