Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update to groovy 4.0.21 #4458

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

chore(deps): update to groovy 4.0.21 #4458

wants to merge 11 commits into from
+194 −99

Conversation

venetrius
Copy link
Member

related to: #3679

@venetrius venetrius added the ci:no-build Prevents any CI stage from running. label Jun 25, 2024
@venetrius venetrius self-assigned this Jun 25, 2024
@venetrius venetrius added ci:h2 Runs the builds for the H2 database. ci:e2e Runs the frontend end-to-end tests. ci:all-as Runs the builds for all application servers. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:jdk Runs the builds for all supported Java versions. ci:migration Runs the process instance migration builds. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:rolling-update Runs the rolling update builds. and removed ci:no-build Prevents any CI stage from running. labels Jun 25, 2024
@venetrius venetrius mentioned this pull request Jun 26, 2024
Open
1 task
@venetrius venetrius added bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. and removed bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. labels Jun 26, 2024
@camunda camunda deleted a comment from github-actions bot Jul 1, 2024
@camunda camunda deleted a comment from github-actions bot Jul 1, 2024
@venetrius venetrius added bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. and removed bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. labels Jul 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited by venetrius
Loading

Java dependency diff

🔄 camunda-root: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
 └─ 🔄 camunda-parent: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
     └─ 🔄 camunda-database-settings: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         ├─ 🔄 camunda-tomcat: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │   ├─ 🔄 camunda-tomcat-assembly: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │   │   ├─ ➕ groovy:4.0.21 ✔  
         │   │   ├─ ➕ groovy-jsr223:4.0.21 ✔  
         │   │   │   └─ ➕ groovy:4.0.21 ✔  
         │   │   ├─ ➕ groovy-json:4.0.21 ✔  
         │   │   │   └─ ➕ groovy:4.0.21 ✔  
         │   │   ├─ ➕ groovy-xml:4.0.21 ✔  
         │   │   │   └─ ➕ groovy:4.0.21 ✔  
         │   │   ├─ ➕ groovy-templates:4.0.21 ✔  
         │   │   │   ├─ ➕ groovy:4.0.21 ✔  
         │   │   │   └─ ➕ groovy-xml:4.0.21 ✔  
         │   │   │       └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-dateutil:4.0.21 ✔  
         │   │   │   └─ ➕ groovy:4.0.21 ✔  
         │   │   └─ ➕ groovy-datetime:4.0.21 ✔  
         │   │       └─ ➕ groovy:4.0.21 ✔  
         │   │   ├─ ➖ groovy:2.4.21 ✔  
         │   │   ├─ ➖ groovy-jsr223:2.4.21 ✔  
         │   │   │   └─ ➖ groovy:2.4.21 ✔  
         │   │   ├─ ➖ groovy-json:2.4.21 ✔  
         │   │   │   └─ ➖ groovy:2.4.21 ✔  
         │   │   ├─ ➖ groovy-xml:2.4.21 ✔  
         │   │   │   └─ ➖ groovy:2.4.21 ✔  
         │   │   └─ ➖ groovy-templates:2.4.21 ✔  
         │   │       ├─ ➖ groovy:2.4.21 ✔  
         │   │       └─ ➖ groovy-xml:2.4.21 ✔  
         │   │           └─ (Repeating subtree omitted)  
         │   └─ 🔄 camunda-bpm-tomcat: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │       └─ 🔄 camunda-tomcat-assembly: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │           ├─ ➕ groovy:4.0.21 ✔  
         │           ├─ ➕ groovy-jsr223:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➕ groovy-json:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➕ groovy-xml:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➕ groovy-templates:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➕ groovy-dateutil:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           └─ ➕ groovy-datetime:4.0.21 ✔  
         │               └─ (Repeating subtree omitted)  
         │           ├─ ➖ groovy:2.4.21 ✔  
         │           ├─ ➖ groovy-jsr223:2.4.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➖ groovy-json:2.4.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➖ groovy-xml:2.4.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           └─ ➖ groovy-templates:2.4.21 ✔  
         │               └─ (Repeating subtree omitted)  
         ├─ 🔄 camunda-bpm-run-root: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │   ├─ 🔄 camunda-bpm-run-assembly: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │   │   ├─ ➕ groovy-jsr223:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-json:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-xml:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-templates:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-dateutil:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   └─ ➕ groovy-datetime:4.0.21 ✔  
         │   │       └─ (Repeating subtree omitted)  
         │   │   ├─ ➖ groovy-jsr223:2.4.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➖ groovy-json:2.4.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➖ groovy-xml:2.4.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   └─ ➖ groovy-templates:2.4.21 ✔  
         │   │       └─ (Repeating subtree omitted)  
         │   └─ 🔄 camunda-bpm-run: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │       └─ 🔄 camunda-bpm-run-assembly: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │           ├─ ➕ groovy-jsr223:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➕ groovy-json:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➕ groovy-xml:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➕ groovy-templates:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➕ groovy-dateutil:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           └─ ➕ groovy-datetime:4.0.21 ✔  
         │               └─ (Repeating subtree omitted)  
         │           ├─ ➖ groovy-jsr223:2.4.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➖ groovy-json:2.4.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➖ groovy-xml:2.4.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           └─ ➖ groovy-templates:2.4.21 ✔  
         │               └─ (Repeating subtree omitted)  
         ├─ 🔄 camunda-wildfly: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │   ├─ 🔄 camunda-wildfly-modules: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │   │   ├─ ➕ groovy:4.0.21 ✔  
         │   │   ├─ ➕ groovy-jsr223:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-json:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-xml:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-templates:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-dateutil:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   └─ ➕ groovy-datetime:4.0.21 ✔  
         │   │       └─ (Repeating subtree omitted)  
         │   │   ├─ ➖ groovy:2.4.21 ✔  
         │   │   ├─ ➖ groovy-jsr223:2.4.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➖ groovy-json:2.4.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➖ groovy-xml:2.4.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   └─ ➖ groovy-templates:2.4.21 ✔  
         │   │       └─ (Repeating subtree omitted)  
         │   ├─ 🔄 camunda-wildfly-assembly: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │   │   └─ 🔄 camunda-wildfly-modules: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │   │       └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy:4.0.21 ✔  
         │   │   ├─ ➕ groovy-jsr223:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-json:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-xml:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-templates:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➕ groovy-dateutil:4.0.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   └─ ➕ groovy-datetime:4.0.21 ✔  
         │   │       └─ (Repeating subtree omitted)  
         │   │   ├─ ➖ groovy:2.4.21 ✔  
         │   │   ├─ ➖ groovy-jsr223:2.4.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➖ groovy-json:2.4.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   ├─ ➖ groovy-xml:2.4.21 ✔  
         │   │   │   └─ (Repeating subtree omitted)  
         │   │   └─ ➖ groovy-templates:2.4.21 ✔  
         │   │       └─ (Repeating subtree omitted)  
         │   └─ 🔄 camunda-bpm-wildfly: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │       └─ 🔄 camunda-wildfly-assembly: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
         │           ├─ ➕ groovy:4.0.21 ✔  
         │           ├─ ➕ groovy-jsr223:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➕ groovy-json:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➕ groovy-xml:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➕ groovy-templates:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➕ groovy-dateutil:4.0.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           └─ ➕ groovy-datetime:4.0.21 ✔  
         │               └─ (Repeating subtree omitted)  
         │           ├─ ➖ groovy:2.4.21 ✔  
         │           ├─ ➖ groovy-jsr223:2.4.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➖ groovy-json:2.4.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           ├─ ➖ groovy-xml:2.4.21 ✔  
         │           │   └─ (Repeating subtree omitted)  
         │           └─ ➖ groovy-templates:2.4.21 ✔  
         │               └─ (Repeating subtree omitted)  
         └─ 🔄 camunda-wildfly26: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
             └─ 🔄 camunda-wildfly26-modules: 7.22.0-SNAPSHOT => 7.22.0-SNAPSHOT  
                 ├─ ➕ groovy:4.0.21 ✔  
                 ├─ ➕ groovy-jsr223:4.0.21 ✔  
                 │   └─ (Repeating subtree omitted)  
                 ├─ ➕ groovy-json:4.0.21 ✔  
                 │   └─ (Repeating subtree omitted)  
                 ├─ ➕ groovy-xml:4.0.21 ✔  
                 │   └─ (Repeating subtree omitted)  
                 ├─ ➕ groovy-templates:4.0.21 ✔  
                 │   └─ (Repeating subtree omitted)  
                 ├─ ➕ groovy-dateutil:4.0.21 ✔  
                 │   └─ (Repeating subtree omitted)  
                 └─ ➕ groovy-datetime:4.0.21 ✔  
                     └─ (Repeating subtree omitted)  
                 ├─ ➖ groovy:2.4.21 ✔  
                 ├─ ➖ groovy-jsr223:2.4.21 ✔  
                 │   └─ (Repeating subtree omitted)  
                 ├─ ➖ groovy-json:2.4.21 ✔  
                 │   └─ (Repeating subtree omitted)  
                 ├─ ➖ groovy-xml:2.4.21 ✔  
                 │   └─ (Repeating subtree omitted)  
                 └─ ➖ groovy-templates:2.4.21 ✔  
                     └─ (Repeating subtree omitted)

Module details

groovy:2.4.21

Declared licenses:

  • Apache-2.0 ✔

Links:

groovy-jsr223:2.4.21

Declared licenses:

  • Apache-2.0 ✔

Links:

groovy-json:2.4.21

Declared licenses:

  • Apache-2.0 ✔

Links:

groovy-xml:2.4.21

Declared licenses:

  • Apache-2.0 ✔

Links:

groovy-templates:2.4.21

Declared licenses:

  • Apache-2.0 ✔

Links:

groovy:4.0.21

Declared licenses:

  • Apache-2.0 ✔

Links:

groovy-jsr223:4.0.21

Declared licenses:

  • Apache-2.0 ✔

Links:

groovy-json:4.0.21

Declared licenses:

  • Apache-2.0 ✔

Links:

groovy-xml:4.0.21

Declared licenses:

  • Apache-2.0 ✔

Links:

groovy-templates:4.0.21

Declared licenses:

  • Apache-2.0 ✔

Links:

groovy-dateutil:4.0.21

Declared licenses:

  • Apache-2.0 ✔

Links:

groovy-datetime:4.0.21

Declared licenses:

  • Apache-2.0 ✔

Links:

Checklist

Unique changes

Unique additions

Developer comments

Glossary

Limitations

  • The reported transitive dependencies may not always be accurate in a multi-module project.
    The SBOM file format represents a unique dependency (coordinates + type) only once. In a multi-module
    project a dependency can be declared in multiple locations with different exclusions of transitive dependencies
    or different version overrides for transitive dependencies.

Emojies

  • ✔: All licenses are on the Go list
  • ⚠: (At least one) license is on the Caution list
  • ❌: (At least one) license is on the Stop list
  • ❓: (At least one) license cannot be determined or is unknown
  • ‼: Dependency has multiple licenses declared
  • ⬆: New dependency version is higher than previous
  • ⬇: New dependency version is lower than previous
  • 🔄: Dependency version is equal and the dependencies of this component changed (e.g. when comparing snapshots)
  • 🤷: The change of the dependency version can not be determined further (e.g. because the version does not follow semantic versioning)

@venetrius
Copy link
Member Author

Dependency check result:

Updated dependencies:

groovy, groovy-jsr223, groovy-json, groovy-xml, groovy-templates
version changed from 2.4.21 -> 4.0.21
license stayed Apache License 2.0

New dependencies:
groovy-dateutil and groovy-datetime version 4.0.21 & license Apache License 2.0

yanavasileva
yanavasileva reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, I have left a few questions.

parent/pom.xml Show resolved Hide resolved
internal-dependencies/pom.xml Outdated Show resolved Hide resolved
qa/test-old-engine/pom.xml Show resolved Hide resolved
yanavasileva
yanavasileva reviewed Jul 4, 2024
View reviewed changes
parent/pom.xml Outdated Show resolved Hide resolved
yanavasileva
yanavasileva approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for considering my feedback. I also did a small manual test, looks good.

yanavasileva
yanavasileva requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Tomcat 10 changes are merged, the PR should be updated and new files should reflect groovy update.

@venetrius venetrius force-pushed the 3679-groovy-4 branch 2 times, most recently from 0347dc4 to 0cbdea9 Compare August 1, 2024 11:46
yanavasileva and others added 10 commits August 1, 2024 14:37
@yanavasileva @venetrius
chore(deps): update to groovy 4.0.13
badb3df 
Cherry picked e435f36
Conflicts:
	distro/wildfly/modules/src/main/modules/org/camunda/bpm/camunda-engine/main/module.xml
	engine-spring/compatibility-test-spring4/pom.xml

related to: #3679
@venetrius
chore(spin): update script test for groovy 4
3349755
@yanavasileva @venetrius
adjust assembly.xml
d56a3d5
@venetrius
chore(deps): use groovy 2.x in 7.10 testFixture
1068df2 
related to: #3679
@venetrius
chore(deps): bump groovy to 4.0.21
3469dbf 
retaled to: #3679
@venetrius
chore(deps): add groovy dateutil & datetime
0a852b1 
    retaled to: #3679
@venetrius
chore(deps): groovy dateutil & datetime not needed in internal-depend…
7fd7572 
…encies/pom.xml

related to #3679
@venetrius
chore(deps): bump groovy to 4.0.21
6e3c1aa 
retaled to: #3679
@venetrius
chore(qa/tomcat9-runtime) update groovy version
649c622 
related to: #3679
@venetrius
chore(distro): copy groovy dependencies to single dir
0c1e3dc 
related to: #3679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanavasileva yanavasileva yanavasileva requested changes

Assignees

@venetrius venetrius

Labels
bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. ci:all-as Runs the builds for all application servers. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:e2e Runs the frontend end-to-end tests. ci:h2 Runs the builds for the H2 database. ci:jdk Runs the builds for all supported Java versions. ci:migration Runs the process instance migration builds. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:rolling-update Runs the rolling update builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@venetrius @yanavasileva