Skip to content

Commit

Permalink
remove telemetry in distro/run and spring-boot-starter
Browse files Browse the repository at this point in the history
  • Loading branch information
yanavasileva committed Jul 12, 2024
1 parent a370fe1 commit 74ea9e7
Show file tree
Hide file tree
Showing 17 changed files with 12 additions and 30 deletions.
3 changes: 0 additions & 3 deletions distro/run/core/src/test/resources/application.yml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ camunda.bpm:
admin-user:
id: demo
password: demo
generic-properties.properties:
telemetry-reporter-activate: false
run.example.enabled: true

spring.datasource:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ camunda.bpm:
admin-user:
id: demo
password: demo
generic-properties.properties:
telemetry-reporter-activate: false
run.example.enabled: false

spring.datasource:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
camunda.bpm.generic-properties.properties.telemetry-reporter-activate=false
spring.liquibase.change-log=classpath:org/camunda/bpm/engine/db/liquibase/camunda-changelog.xml

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

import org.camunda.bpm.engine.ProcessEngine;
import org.camunda.bpm.engine.RuntimeService;
import org.camunda.bpm.engine.impl.telemetry.TelemetryRegistry;
import org.camunda.bpm.engine.impl.diagnostics.DiagnosticsRegistry;
import org.camunda.bpm.engine.impl.telemetry.dto.ApplicationServerImpl;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand Down Expand Up @@ -52,10 +52,10 @@ public void shouldStartApplicationSuccessfully() {
@Test
public void shouldNotDetermineApplicationServer() {

TelemetryRegistry telemetryRegistry = processEngine.getProcessEngineConfiguration().getTelemetryRegistry();
DiagnosticsRegistry diagnosticsRegistry = processEngine.getProcessEngineConfiguration().getDiagnosticsRegistry();

// then
ApplicationServerImpl applicationServer = telemetryRegistry.getApplicationServer();
ApplicationServerImpl applicationServer = diagnosticsRegistry.getApplicationServer();
assertThat(applicationServer).isNull();
}

Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
server.port: 58080

camunda.bpm.generic-properties.properties.telemetry-reporter-activate: false

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,3 @@ camunda.bpm.job-execution.active=true
camunda.bpm.database.schema-update=true

spring.main.allow-bean-definition-overriding=true

camunda.bpm.generic-properties.properties.telemetry-reporter-activate=false

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

import org.camunda.bpm.engine.ProcessEngine;
import org.camunda.bpm.engine.impl.cfg.ProcessEngineConfigurationImpl;
import org.camunda.bpm.engine.impl.telemetry.CamundaIntegration;
import org.camunda.bpm.engine.impl.diagnostics.CamundaIntegration;
import org.springframework.beans.factory.InitializingBean;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
Expand All @@ -31,6 +31,7 @@ public class CamundaIntegrationDeterminator implements InitializingBean {
@Autowired
protected ProcessEngine processEngine;

@Override
public void afterPropertiesSet() throws Exception {
ProcessEngineConfigurationImpl configuration = (ProcessEngineConfigurationImpl) processEngine.getProcessEngineConfiguration();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
import java.util.Set;

import org.camunda.bpm.engine.impl.cfg.ProcessEngineConfigurationImpl;
import org.camunda.bpm.engine.impl.telemetry.CamundaIntegration;
import org.camunda.bpm.engine.impl.telemetry.TelemetryRegistry;
import org.camunda.bpm.engine.impl.diagnostics.CamundaIntegration;
import org.camunda.bpm.engine.impl.diagnostics.DiagnosticsRegistry;
import org.camunda.bpm.engine.impl.telemetry.dto.ApplicationServerImpl;
import org.camunda.bpm.engine.impl.telemetry.dto.TelemetryDataImpl;
import org.camunda.bpm.spring.boot.starter.test.nonpa.TestApplication;
Expand All @@ -41,10 +41,10 @@ public class TelemetryNonPaIT extends AbstractCamundaAutoConfigurationIT {

@Test
public void shouldSubmitApplicationServerData() {
TelemetryRegistry telemetryRegistry = processEngine.getProcessEngineConfiguration().getTelemetryRegistry();
DiagnosticsRegistry diagnosticsRegistry = processEngine.getProcessEngineConfiguration().getDiagnosticsRegistry();

// then
ApplicationServerImpl applicationServer = telemetryRegistry.getApplicationServer();
ApplicationServerImpl applicationServer = diagnosticsRegistry.getApplicationServer();
assertThat(applicationServer).isNotNull();
assertThat(applicationServer.getVendor()).isEqualTo("Apache Tomcat");
assertThat(applicationServer.getVersion()).isNotNull();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

import static org.assertj.core.api.Assertions.assertThat;

import org.camunda.bpm.engine.impl.telemetry.TelemetryRegistry;
import org.camunda.bpm.engine.impl.diagnostics.DiagnosticsRegistry;
import org.camunda.bpm.engine.impl.telemetry.dto.ApplicationServerImpl;
import org.camunda.bpm.spring.boot.starter.test.pa.TestProcessApplication;
import org.junit.Test;
Expand All @@ -38,10 +38,10 @@ public class TelemetryPaIT extends AbstractCamundaAutoConfigurationIT {

@Test
public void shouldSubmitApplicationServerData() {
TelemetryRegistry telemetryRegistry = processEngine.getProcessEngineConfiguration().getTelemetryRegistry();
DiagnosticsRegistry diagnosticsRegistry = processEngine.getProcessEngineConfiguration().getDiagnosticsRegistry();

// then
ApplicationServerImpl applicationServer = telemetryRegistry.getApplicationServer();
ApplicationServerImpl applicationServer = diagnosticsRegistry.getApplicationServer();
assertThat(applicationServer).isNotNull();
assertThat(applicationServer.getVendor()).isEqualTo("Apache Tomcat");
assertThat(applicationServer.getVersion()).isNotNull();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
camunda.bpm.generic-properties.properties.telemetry-reporter-activate=false
camunda.bpm.generic-properties.properties.enforce-history-time-to-live=false

0 comments on commit 74ea9e7

Please sign in to comment.