Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Mapillary images by organzation_id #9540

Merged
merged 3 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/options.js
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,7 @@ export function buildStyle(styleDescriptor) {
* @property {string} viewer The viewer to use (google or mapillary)
* @property {string} key ClientId for Mapillary
* @property {number} [bufferSize] Buffer size in pixels for Mapillary bbox
* @property {string} [organizationId] The id of the Mapillary organization to get images from.
*/

/**
Expand Down
61 changes: 61 additions & 0 deletions src/streetview/MapillaryGraphQueryCreator.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
/**
* Mapillary GraphQueryCreator which allow filtering by organisation_id.
*/
export default class MapillaryGraphQueryCreator {
/**
* @param {string} organizationId The id of the organization to get images from.
*/
constructor(organizationId) {
this.organizationId = organizationId;

this.imagesPath = 'images';
this.sequencePath = 'image_ids';
this._imageTilesPath = 'tiles';

this.coreFields = ['computed_geometry', 'geometry', 'sequence'];
this.idFields = ['id'];
this.spatialFields = [
'altitude',
'atomic_scale',
'camera_parameters',
'camera_type',
'captured_at',
'compass_angle',
'computed_altitude',
'computed_compass_angle',
'computed_rotation',
'creator',
'exif_orientation',
'height',
'merge_cc',
'mesh',
'organization',
'quality_score',
'sfm_cluster',
'thumb_1024_url',
'thumb_2048_url',
'width',
];
this.imageTileFields = ['url', 'z', 'x', 'y'];
}

images(imageIds, fields) {
return `image_ids=${imageIds.join(',')}&fields=${fields.join(',')}`;
}

imagesS2(cellId, fields) {
return `organization_id=${this.organizationId}&s2=${cellId}&fields=${fields.join(',')}`;
}

imageTiles(z, fields) {
return `z=${z}&fields=${fields.join(',')}`;
}

imageTilesPath(imageId) {
return `${imageId}/${this._imageTilesPath}`;
}

sequence(sequenceId) {
return `sequence_id=${sequenceId}`;
}
}
54 changes: 49 additions & 5 deletions src/streetview/MapillaryService.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
// IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
// CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
import {StreetviewService} from './Service';
import MapillaryGraphQueryCreator from './MapillaryGraphQueryCreator';
import {buffer} from 'ol/extent';
const MLY_METADATA_ENDPOINT = 'https://graph.mapillary.com';

Expand All @@ -34,8 +35,18 @@ export default class MapillaryService extends StreetviewService {
* @param {(newCoordinates: import('ol/coordinate').Coordinate | null) => void} handlePanoramaPositionChange Position change handler.
* @param {string} accessToken The key to access the mapillary api.
* @param {number} bufferSize The size to add to the bbox buffer.
* @param {string} organizationId The id of the organization to get images from.
*/
constructor($scope, $timeout, $http, map, handlePanoramaPositionChange, accessToken, bufferSize) {
constructor(
$scope,
$timeout,
$http,
map,
handlePanoramaPositionChange,
accessToken,
bufferSize,
organizationId,
) {
super($scope, map, handlePanoramaPositionChange);

/**
Expand Down Expand Up @@ -65,14 +76,20 @@ export default class MapillaryService extends StreetviewService {
*/
this.bufferSizePx_ = bufferSize || 10;

/**
* The organization to get images from (filter images by organisation_id).
*
* @private
*/
this.organizationId = organizationId;

/**
* Container of the mapillary viewer.
*/
this.mapillaryElement = document.getElementById('mly');
this.mapillaryElement.hidden = true;
import(/* webpackChunkName: "mapillary" */ 'mapillary-js').then((Mapillary) => {
this.Mapillary = Mapillary;
this.mly = new Mapillary.Viewer({
const viewerOptions = {
accessToken: this.accessToken_,
container: 'mly',
component: {
Expand All @@ -81,7 +98,25 @@ export default class MapillaryService extends StreetviewService {
visible: false,
},
},
});
};

if (this.organizationId) {
const queryCreator = new MapillaryGraphQueryCreator(this.organizationId);

const dataProvider = new Mapillary.GraphDataProvider(
{
accessToken: this.accessToken_,
},
undefined,
undefined,
queryCreator,
);
viewerOptions.dataProvider = dataProvider;
}

this.Mapillary = Mapillary;
this.mly = new Mapillary.Viewer(viewerOptions);

window.addEventListener('resize', () => {
this.resize();
});
Expand Down Expand Up @@ -167,7 +202,16 @@ export default class MapillaryService extends StreetviewService {
*/
searchImage_(bbox) {
const baseUrl = `${MLY_METADATA_ENDPOINT}/images`;
const path = `${baseUrl}?access_token=${this.accessToken_}&fields=id&bbox=${bbox}&limit=1`;
const params = new URLSearchParams([
['access_token', this.accessToken_],
['fields', 'id'],
['bbox', bbox],
['limit', '1'],
]);
if (this.organizationId) {
params.append('organization_id', this.organizationId);
}
const path = `${baseUrl}?${params.toString()}`;
return this.$http_.get(path).then(
/**
* @param {any} response object.
Expand Down
2 changes: 2 additions & 0 deletions src/streetview/component.js
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,7 @@ class StreetviewController {
}
const accessToken = this.options.key;
const bufferSize = this.options.bufferSize;
const organizationId = this.options.organizationId;
//wait for the mly div to be there before making the service which needs it
this.timeout_(() => {
const mapillaryService = new MapillaryService(
Expand All @@ -327,6 +328,7 @@ class StreetviewController {
this.handlePanoramaPositionChange_,
accessToken,
bufferSize,
organizationId,
);
this.scope_.$watch(
() => this.panelWidth,
Expand Down
Loading