Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish as es6 #9474

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Publish as es6 #9474

merged 5 commits into from
Sep 17, 2024

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin commented Sep 13, 2024 •
edited
Loading

Draft to let the CI test some changes.

See JIRA issue: GSNGEO-14.
Examples
Storybook
API help
API documentation

Main work:

  1. Clean ts-config files and make them transpile/copy all the source code in a distlib folder. this folder contains .js, js.map and, d.ts files.
  2. Make example usable by passing sass warning as... warning, but only for the cli, and not hover the example (webpack ~error).
  3. Split dependencies into dev, optional and peer dependencies.

We could also add a files key in the package.json to NOT publish everything. TBD

@ger-benjamin ger-benjamin self-assigned this Sep 13, 2024
@ger-benjamin ger-benjamin force-pushed the GSNGEO-14-publish-as-es6 branch 4 times, most recently from a9218cc to bb3d566 Compare September 13, 2024 12:44
sbrunner
sbrunner reviewed Sep 13, 2024
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
@ger-benjamin ger-benjamin force-pushed the GSNGEO-14-publish-as-es6 branch from bb3d566 to dbd2b69 Compare September 13, 2024 13:15
@ger-benjamin ger-benjamin force-pushed the GSNGEO-14-publish-as-es6 branch from dbd2b69 to b593435 Compare September 13, 2024 13:46
@ger-benjamin ger-benjamin marked this pull request as ready for review September 13, 2024 13:46
sbrunner
sbrunner reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions that we should decide what we want to do with them :-)

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ger-benjamin ger-benjamin force-pushed the GSNGEO-14-publish-as-es6 branch from 6964e71 to 686dbbd Compare September 17, 2024 11:56
@ger-benjamin
Remove more dependencies
777e20f 
Remove core-js:
It looks to be a bunch of pollyfill.
I would like to remove it, and then ev. patch the issues with
dedicated well-know pollyfill

regenerator-runtime:
Was imported in src/controllers/bootstrap.js, but probably not used
anymore.

Cheerio
Is probably not worth to fix it as subdependencies

resize-observer-polyfill
Should not be necessary anymore in 2024
@ger-benjamin ger-benjamin force-pushed the GSNGEO-14-publish-as-es6 branch from 686dbbd to 777e20f Compare September 17, 2024 12:13
@ger-benjamin
Copy link
Member Author

Looks good, I merge :-)

@ger-benjamin ger-benjamin merged commit 42a9f95 into master Sep 17, 2024
13 checks passed
@ger-benjamin ger-benjamin deleted the GSNGEO-14-publish-as-es6 branch September 17, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees

@ger-benjamin ger-benjamin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ger-benjamin @sbrunner