Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the files using babel-plugin-angularjs-annotate #9453

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Aug 28, 2024

Using the command:
npx babel --plugins babel-plugin-angularjs-annotate <file>

See JIRA issue: GSNGEO-10.
Examples
Storybook
API help
API documentation

@sbrunner sbrunner force-pushed the ngInject-GSNGEO-10 branch from 504a905 to 46813be Compare August 28, 2024 08:13
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks that we are not alone with this issue :-)

Are all the line removal and lint-like things wanted ?
I mean, I saw the dedicated commit, but why now ?

@sbrunner
Copy link
Member Author

It's not the linting but the Babel transformation (will be realy hard to add them back...)

@ger-benjamin
Copy link
Member

No it's okay like this. I was just surprised.

@sbrunner sbrunner merged commit 8a91bb7 into master Aug 28, 2024
13 checks passed
@sbrunner sbrunner deleted the ngInject-GSNGEO-10 branch August 28, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants