Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SVG build-time modifications #9448

Closed
wants to merge 1 commit into from
Closed

Remove SVG build-time modifications #9448

wants to merge 1 commit into from

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Aug 27, 2024 •
edited by jira bot
Loading

@sbrunner sbrunner force-pushed the svg-GSNGEO-12 branch 12 times, most recently from d763ef7 to 2a4b6bf Compare August 27, 2024 15:18
@sbrunner sbrunner requested a review from ger-benjamin August 27, 2024 15:59
@sbrunner sbrunner marked this pull request as ready for review August 27, 2024 15:59
@ger-benjamin
Copy link
Member

The goal is full filled, but the result is a bit ugly.
Do you have envisaged to load svg icon/images via css ?

@sbrunner
Copy link
Member Author

sbrunner commented Aug 28, 2024 •
edited
Loading

Do you have envisaged to load svg icon/images via css?

This kind of configuration is so difficult to make it wheel working, then no...

@sbrunner
Copy link
Member Author

An alternative can be to make JS file per icon, and include them in the template, then they are in JS also!

@sbrunner
Copy link
Member Author

=> Moved in #9454

@sbrunner sbrunner closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin Awaiting requested review from ger-benjamin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @ger-benjamin