Update typescript-eslint monorepo to v8 (master) (major)

.eslintrc.yaml

@@ -7,7 +7,6 @@ extends:
   - plugin:lit/recommended
 
 plugins:
-  - copyright
   - '@typescript-eslint'
 
 parser: '@typescript-eslint/parser'
@@ -34,7 +33,6 @@ rules:
     - error
     - nofunc
   no-var: error
-  copyright/copyright: error
   jsdoc/require-param-type: off
   jsdoc/require-property-type: off
   jsdoc/require-returns-type: off
@@ -61,6 +59,11 @@ rules:
   '@typescript-eslint/no-misused-promises': warn
   '@typescript-eslint/require-await': warn
   '@typescript-eslint/no-unsafe-argument': warn
+  '@typescript-eslint/no-unused-vars': warn
+  '@typescript-eslint/no-unused-expressions': warn
+  '@typescript-eslint/prefer-promise-reject-errors': warn
+  # TODO: Remove before release 2.9
+  '@typescript-eslint/no-require-imports': warn
   '@typescript-eslint/no-useless-constructor': error
   '@typescript-eslint/prefer-for-of': error
   '@typescript-eslint/prefer-includes': error

Makefile

@@ -199,11 +199,7 @@ examples-hosted-apps: .build/gmf-apps.timestamp
 	npm run build-gmf-apps
 	touch $@
 
-.build/node_modules.copyright.timestamp: .build/node_modules.timestamp
-	npm install --no-save --omit=optional --no-package-lock ./buildtools/copyright
-	touch $@
-
-.build/eslint.timestamp: .build/node_modules.copyright.timestamp .eslintrc.yaml \
+.build/eslint.timestamp: .eslintrc.yaml \
 		$(API_JS_FILES) \
 		$(NGEO_JS_FILES) \
 		$(NGEO_TEST_JS_FILES) \
@@ -212,24 +208,24 @@ examples-hosted-apps: .build/gmf-apps.timestamp
 		$(GMF_EXAMPLES_JS_FILES) \
 		$(GMF_APPS_JS_FILES) \
 		$(BUILD_JS_FILES)
-	./node_modules/.bin/eslint $(filter-out .build/node_modules.copyright.timestamp .eslintrc.yaml, $^)
+	./node_modules/.bin/eslint $(filter-out .eslintrc.yaml, $^)
 	touch $@
 
-.build/eslint-ts.timestamp: .build/node_modules.copyright.timestamp .eslintrc.yaml \
+.build/eslint-ts.timestamp: .eslintrc.yaml \
 		$(TS_FILES)
-	./node_modules/.bin/eslint --max-warnings=0 $(filter-out .build/node_modules.copyright.timestamp .eslintrc.yaml .eslintrc-ts.yaml, $^)
+	./node_modules/.bin/eslint --max-warnings=0 $(filter-out .eslintrc.yaml .eslintrc-ts.yaml, $^)
 	touch $@
 
 .PHONY: eslint-fix
-eslint-fix: .build/node_modules.copyright.timestamp .eslintrc.yaml \
+eslint-fix: .eslintrc.yaml \
 		$(API_JS_FILES) \
 		$(NGEO_JS_FILES) \
 		$(NGEO_TEST_JS_FILES) \
 		$(NGEO_EXAMPLES_JS_FILES) \
 		$(GMF_EXAMPLES_JS_FILES) \
 		$(GMF_APPS_JS_FILES) \
 		$(BUILD_JS_FILES)
-	./node_modules/.bin/eslint --fix $(filter-out .build/node_modules.copyright.timestamp .eslintrc.yaml, $^)
+	./node_modules/.bin/eslint --fix $(filter-out .eslintrc.yaml, $^)
 
 .build/examples-hosted/partials: examples/partials/
 	mkdir -p $(dir $@)

buildtools/.eslintrc.yaml

@@ -1,9 +1,6 @@
 extends:
   - eslint:recommended
 
-plugins:
-  - copyright
-
 parserOptions:
   sourceType: module
   ecmaVersion: 2020
@@ -23,4 +20,3 @@ rules:
     - error
     - nofunc
   no-var: error
-  copyright/copyright: error

buildtools/codeshift-js2ts.js

@@ -566,7 +566,7 @@ function visit(indent, node, call) {
   if (!done) {
     console.log('Unknown node type');
     console.log(node);
-    throw 'Unknown node type';
+    throw new Error('Unknown node type');
   }
 }
 

buildtools/svg-viewbox-loader.js

@@ -41,6 +41,7 @@ module.exports = function (source) {
   let tokens = simpleHTMLTokenizer.tokenize(source);
 
   tokens = tokens.map((tag) => {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
     if (tag.type === 'StartTag' && tag.tagName === 'svg') {
       let width = undefined;
       let height = undefined;

lib/.eslintrc.yaml

@@ -1,2 +1 @@
-rules:
-  copyright/copyright: 0
+rules: {}

package.json

@@ -99,8 +99,8 @@
     "@types/sinon": "17.0.3",
     "@types/tinycolor2": "1.4.6",
     "@types/typeahead": "0.11.32",
-    "@typescript-eslint/eslint-plugin": "5.62.0",
-    "@typescript-eslint/parser": "5.62.0",
+    "@typescript-eslint/eslint-plugin": "8.2.0",
+    "@typescript-eslint/parser": "8.2.0",
     "angular": "1.8.3",
     "angular-animate": "1.8.3",
     "angular-dynamic-locale": "0.1.38",

src/controllers/bootstrap.js

@@ -112,7 +112,7 @@ function bootstrap(module) {
       angular.bootstrap(document, [appName]);
     })
     .catch((error) => {
-      window.alert(`Failed to get the dynamic: ${error}`);
+      window.alert(`Failed to get the dynamic: ${error}`); // eslint-disable-line @typescript-eslint/no-base-to-string
     });
 }
 

src/e2e/mobile.spec.ts

@@ -464,7 +464,7 @@ if (Cypress.browser.isHeaded) {
           cy.wrap(btn)
             .click({force: true})
             .then((btn) => {
-              expect(btn).to.not.be.visible;
+              expect(btn).to.not.be.visible; // eslint-disable-line @typescript-eslint/no-unused-expressions
 
               // Check the placeholder
               cy.get('.tt-input').should('have.attr', 'placeholder', 'Search…');

src/lidar/Manager.ts

@@ -421,7 +421,7 @@ export class LidarprofileManager {
         this.processBuffer_(data, iter, distanceOffset, lastLOD, resetPlot);
       })
       .catch((err: Error) => {
-        throw `Error on pytree query: ${err.message}`;
+        throw new Error(`Error on pytree query: ${err.message}`);
       });
   }
 
@@ -470,6 +470,7 @@ export class LidarprofileManager {
 
     try {
       JSON.parse(strHeaderLocal);
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
     } catch (e) {
       if (!this.isPlotSetup_) {
         const canvas: any = d3select(lidarContainerElement.querySelector('.lidar-canvas'));

src/lidar/PanelElement.ts

@@ -257,7 +257,7 @@ export default class GmfLidarPanel extends ToolPanelElement {
    * @param key The key string of the toggled classification.
    */
   toggleVisibility(classification: LidarprofileServerConfigClassification, key: string): void {
-    classification.visible === 0 ? (classification.visible = 1) : (classification.visible = 0);
+    classification.visible = classification.visible === 0 ? 1 : 0;
     this.setClassification(classification, parseInt(key));
   }
 

src/lidar/Plot.ts

@@ -502,7 +502,7 @@ export default class {
       source.clear();
       const lidarPointGeom = new olGeomPoint([p.coords[0], p.coords[1]]);
       const lidarPointFeature = new olFeature(lidarPointGeom);
-      if (typeof pointClassification.color !== undefined) {
+      if (pointClassification.color !== undefined) {
         lidarPointFeature.setStyle(
           new olStyleStyle({
             image: new olStyleCircle({

src/message/Disclaimer.js

@@ -337,7 +337,7 @@ export class MessageDisclaimerService extends ngeoMessageMessage {
         jqueryObj.alert('close');
       }
     } else {
-      console.log(`No disclaimer found for  '${message}'.`);
+      console.log(`No disclaimer found for '${message.msg}'.`);
     }
 
     // (3) Remove message from cache since it's closed now.

src/message/Notification.ts

@@ -106,16 +106,16 @@ export class MessageNotification extends ngeoMessageMessage {
 
     const classNames = ['alert', 'fade', 'show'];
     switch (type) {
-      case MessageType.ERROR:
+      case MessageType.ERROR: // eslint-disable-line @typescript-eslint/no-unsafe-enum-comparison
         classNames.push('alert-danger');
         break;
-      case MessageType.INFORMATION:
+      case MessageType.INFORMATION: // eslint-disable-line @typescript-eslint/no-unsafe-enum-comparison
         classNames.push('alert-info');
         break;
-      case MessageType.SUCCESS:
+      case MessageType.SUCCESS: // eslint-disable-line @typescript-eslint/no-unsafe-enum-comparison
         classNames.push('alert-success');
         break;
-      case MessageType.WARNING:
+      case MessageType.WARNING: // eslint-disable-line @typescript-eslint/no-unsafe-enum-comparison
         classNames.push('alert-warning');
         break;
       default: