Fix lighttpd PATH_INFO extraction with MAPSERVER_BASE_PATH#1373
Open
Fix lighttpd PATH_INFO extraction with MAPSERVER_BASE_PATH#1373
Conversation
Copilot
AI
changed the title
[WIP] Add test case for issue 1108 comment
Fix lighttpd PATH_INFO extraction with MAPSERVER_BASE_PATH
Mar 6, 2026
Member
|
@johannes Does it looks good to you? |
|
I wouldn't use variable names But I am not the person you were looking for :) |
Co-authored-by: sbrunner <353872+sbrunner@users.noreply.github.com>
7e4d0e8 to
86a478c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
path_info.luaused Lua'sgsubwith a pattern built fromMAPSERVER_BASE_PATH, which fails to correctly setrequest.path-infoin lighttpd's mod_magnet environment — breaking mapfile alias resolution andows_onlineresourceconstruction in WMS GetCapabilities when the mapfile is specified as a path component.Changes
runtime/etc/lighttpd/path_info.lua: Replacegsub-based extraction with plain-textfind, as suggested in the upstream report:find(..., 1, true)uses plain-text matching (no pattern interpretation), correctly stripping the base path and leaving the mapfile component asPATH_INFO.acceptance_tests/test_wms.py: Addtest_lighttpd_capabilities_url— verifies thatGetMapoperation URLs in the WMS GetCapabilities response start withBASE_URL_LIGHTTPD(i.e., include the correct base path + mapfile path), catching thePATH_INFOregression described in the issue.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.