ウェブサイト #5
Merged
ウェブサイト #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p1ass
reviewed
Mar 26, 2020
website/components/CustomFooter.vue
Outdated
Comment on lines
2
to
13
| <div> | ||
| <footer class="footer-root"> | ||
| <div class="links"> | ||
| <p v-for="(link, idx) in links" :key="idx"> | ||
| <a :href="link.href" :target="link.target"> | ||
| {{ link.title }} | ||
| </a> | ||
| </p> | ||
| </div> | ||
| <div class="has-text-centered">©2020 CAMPHOR-</div> | ||
| </footer> | ||
| </div> |
website/components/CustomFooter.vue
Outdated
| <footer class="footer-root"> | ||
| <div class="links"> | ||
| <p v-for="(link, idx) in links" :key="idx"> | ||
| <a :href="link.href" :target="link.target"> |
There was a problem hiding this comment.
rel="noopener noreferrer" を付けた方がよさそう
| @@ -0,0 +1,66 @@ | |||
| <template> | |||
| <component | |||
| :is="isInternalLink(path) ? 'nuxt-link' : 'a'" | |||
|
@p1ass 修正しました〜 |
honai
reviewed
Mar 26, 2020
website/components/About.vue
Outdated
| } | ||
|
|
||
| .join { | ||
| > .show-schedule { |
website/components/About.vue
Outdated
| <template> | ||
| <div class="about-root"> | ||
| <div class="container"> | ||
| <div id="join" v-in-viewport class="section join"> |
There was a problem hiding this comment.
Suggested change
| <div id="join" v-in-viewport class="section join"> | |
| <section id="join" v-in-viewport class="section join"> |
見出しがあるまとまりなので
website/components/About.vue
Outdated
| transform: translateY(0px); | ||
| } | ||
| </style> | ||
| <script> |
There was a problem hiding this comment.
このファイルだけ <style> が先にあるので、統一したほうが良いかも
website/components/About.vue
Outdated
| <div class="columns is-vcentered"> | ||
| <div class="column is-two-fifths"> | ||
| <img | ||
| src="https://github.com/camphor-/lab/raw/master/assets/connect-idea.png" |
website/components/About.vue
Outdated
| </div> | ||
| <div class="column"> | ||
| <img | ||
| src="https://github.com/camphor-/lab/raw/master/assets/available-resources.png" |
| <div class="hero-background"></div> | ||
| <div class="lab-hero"> | ||
| <div class="columns is-variable is-5 is-desktop"> | ||
| <div v-in-viewport class="lab-title column has-text-white"> |
There was a problem hiding this comment.
Suggested change
| <div v-in-viewport class="lab-title column has-text-white"> | |
| <section v-in-viewport class="lab-title column has-text-white"> |
見出しをもつまとまりなので
| {{ link.title }} | ||
| </a> | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
div > p > a でリストを作るより ul > li > a で (CSSリセットは必要になるが) したほうがセマンティックWebとしては良いかも
website/components/CustomFooter.vue
Outdated
| export default { | ||
| data() { | ||
| return { | ||
| links |
There was a problem hiding this comment.
変更できる値ではなく定数なので、 computed として返すほうが自然…? (ほんまか?)
website/components/CustomFooter.vue
Outdated
| </a> | ||
| </p> | ||
| </div> | ||
| <div class="has-text-centered">©2020 CAMPHOR-</div> |
There was a problem hiding this comment.
Suggested change
| <div class="has-text-centered">©2020 CAMPHOR-</div> | |
| <div class="has-text-centered">©2020 CAMPHOR-</div> |
のほうが自分は好きです(ほぼ好みです)
website/components/Navbar.vue
Outdated
| > | ||
| {{ item.title }} | ||
| </a> | ||
| </div> |
There was a problem hiding this comment.
ここも ul > li > a でリストにするのが自然かなと思いました
|
@honai せまんちっくうぇぶにしました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
とりあえずトップページだけ
クソデカPRにしてしまった🤷♂️
#1