Modifying setup_script.sh #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birm
approved these changes
Mar 26, 2024
birm
reviewed
Mar 26, 2024
setup_script.sh
Outdated
|
|
||
| # Check for required commands | ||
| check_command "mongoshsh" | ||
| check_command "node.exe" |
There was a problem hiding this comment.
Is this a windows only setup script?
There was a problem hiding this comment.
I have again updated the script based on linux the only difference is that for the windows machine we have to add extension of .exe to both command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered alot of error while trying to run the project and based on the errors that I got I have modified the setup script.
Summary
Which included using mongosh instead of using mongo command beacuse the lastest version does not support mongo command and same goes for node using node.exe instead of node. And I have also reduced the redundant code by making functions
Testing
The changes have been tested locally by running the modified setup script and verifying that it completes without errors. Additionally, I manually inspected the script for potential issues and ensured that all modifications are syntactically correct. However, further testing on different environments may be beneficial to ensure compatibility across various setups.
Questions
@birm I wanted to point out that the links which are present in
RESOURCE_IDX,RESOURCE_DEFAULT_DATA,RESOURCE_COLLECTIONpoint to404: not found page