Fix completions capability naming to match MCP SDK#12
Fix completions capability naming to match MCP SDK#12krzysztofwos wants to merge 2 commits intocameroncooke:mainfrom
Conversation
The MCP SDK (`@modelcontextprotocol/sdk` >=1.25.x) validates server capabilities using the key `completions` (plural), but the proxy was declaring `completion` (singular). This caused a hard error on startup: Error: Server does not support completions (required for completion/complete) Rename the capability key in both the proxy server and the child client capabilities objects. Fixes cameroncooke#9 Made-with: Cursor
WalkthroughThis change updates the MCP completion capability schema declarations in the proxy implementation. The MCPProxy constructor's server capabilities field is renamed from 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
When installing from a GitHub URL (e.g. npm install user/repo#branch), npm runs the `prepare` lifecycle script after cloning. Without it, the `dist/` directory is missing because it's gitignored and never built. Made-with: Cursor
Summary
completioncapability key tocompletions(plural) in both the proxy server and child client capability declarations insrc/mcp-proxy.ts@modelcontextprotocol/sdk>=1.25.x which validates againstcompletionswhen registering theCompleteRequestSchemahandlerProblem
reloaderoo fails to start with:
The SDK's
assertRequestHandlerCapabilitychecksthis._capabilities.completionsbut the proxy declaredcompletion(singular), so the check always fails.Test plan
restart_servertool works, child server restarts successfullyFixes #9
Fixes #8