chore: update_workforce_stop_logic

[fengju0213]

Description

The previous stop design was intended to stop the entire workforce, but there was a logical error that caused running tasks not to actually stop.
This PR fixes that issue by correcting the logic so that calling the stop method properly halts the entire workforce.

Checklist

Go over all the following points, and put an x in all the boxes that apply.

• I have read the CONTRIBUTION guide (required)
• I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
• I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
• I have updated the tests accordingly (required for a bug fix or a new feature)
• I have updated the documentation if needed:
• I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix_workforce_stop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[a7m-1st]

Great handling on the stop and I like to see you implemented the get_in_flight_tasks from #3232. Lastly, is it better to transfer those tasks from task_channel &/ pending_tasks to completed_taks via the _handle_completed_task or clearing them it okay?

Before:

After:

[fengju0213]

_handle_completed_task

Great handling on the stop and I like to see you implemented the get_in_flight_tasks from #3232. Lastly, is it better to transfer those tasks from task_channel &/ pending_tasks to completed_taks via the _handle_completed_task or clearing them it okay?

Before:

After:

we should just remove them ，_handle_completed_task is used to handle completed tasks.

[fengju0213]

@a7m-1st thanks for useful comments！

[a7m-1st]

Thanks for your swift actions @fengju0213 !!

[waleedalzarooni]

LGTM!