feat: Add tool call output cache function in ChatAgent #3296
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hesamsheikh
left a comment
hesamsheikh
left a comment
There was a problem hiding this comment.
Thank you for the PR @MuggleJinx
I added a few comments.
| self._tool_output_cache_threshold = ( | ||
| tool_call_cache_threshold if tool_call_cache_threshold else 2000 |
There was a problem hiding this comment.
I suspect this overrides the tool_call_cache_threshold=0 for caching disabling.
| self, | ||
| input_message: Union[BaseMessage, str], | ||
| response_format: Optional[Type[BaseModel]] = None, | ||
| tool_call_history_cache: bool = False, |
There was a problem hiding this comment.
could we actually rename this to tool_call_cache_history to make it consistent with tool_call_cache_threshold and tool_call_cache_dir?
| def _ensure_tool_cache_lookup_tool(self) -> None: | ||
| if not self._tool_output_cache_enabled: |
There was a problem hiding this comment.
let's add docstrings to these new methods.
| # Multiple cache_ids - return JSON dictionary | ||
| import json |
There was a problem hiding this comment.
json imported in the script already
| return self._tool_output_cache_manager.load(cache_id) | ||
| except FileNotFoundError: | ||
| return ( | ||
| f"Cache entry '{cache_id}' was not found. " | ||
| "Verify the identifier and try again." | ||
| ) |
There was a problem hiding this comment.
why not return the single cache_id as json too to make the types consistent?
Description
Address issue #3376. The previous implementation of the tool cache is improved by adding an argument to control in the
step()function. So the default behavior will not change if it the tool cache argument is set to befalseChecklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!