Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Root cause
Synchronous functions wrapped by with_timeout use a new thread (thread + join) when a timeout is set.
If such functions call asyncio.create_task(...), the new thread has no running event loop, causing RuntimeError: no running event loop and downstream confusing errors.
Fix
In the sync branch of with_timeout, detect a running event loop via asyncio.get_running_loop().
If a loop is running, execute inline (no thread switch, no sync timeout) to preserve the asyncio context.
If no loop is running, keep the original behavior: spawn a thread and enforce timeout with join.
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.Fixes #issue-number
in the PR description (required)pyproject.toml
anduv lock
If you are unsure about any of these, don't hesitate to ask. We are here to help!