Remove duplicate TODO comment in chat_agent.py#5002 #3154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add _deduplicate_with_llm_supervision function - Add _llm_judge_duplicates helper function - Fix circular import issues - Add comprehensive test suite with 9 test cases - Maintain backward compatibility with existing code
- Remove duplicate 'TODO: Handle tool calls' comment on line 1451 - Keep the original TODO comment on line 1409 for proper tracking - This addresses issue camel-ai#3002 by cleaning up redundant comments in codebase
|
@nitpicker55555 review |
|
Hi @shudanluo , thanks for your contribution! However, I noticed that this PR doesn't quite match what the issue is asking for. The issue is about removing outdated features that are no longer needed, For cleaning up outdated features, we should be looking at removing things like:
These are all marked with deprecation warnings and have clear migration paths, making them perfect candidates for removal. Hi @Wendong-Fan are the deprecated items listed above what you meant by "features that we no longer need"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove duplicate TODO comment that was causing code redundancy.
Changes
Related Issue
Addresses #3002 - Clean CAMEL code base