Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddLower, PairwiseAdd/Sub and MaskedAbsOr operations #1

Open
wants to merge 133 commits into
base: master
Choose a base branch
from
Open

AddLower, PairwiseAdd/Sub and MaskedAbsOr operations #1

wants to merge 133 commits into from

Conversation

mazimkhan
Copy link

@mazimkhan mazimkhan commented Nov 18, 2024 •
edited
Loading

Adding special arithmetic operations for arm_sve-inl.h and generic_ops-inl.h:

  • AddLower adds the first lane of both input vectors and passes the lanes of vector a for all other lanes.
  • PairwiseAdd adds consecutive pairs of elements in each of the vectors and interleaves the resulting lanes.
  • PairwiseSub subtracts consecutive pairs of elements in each of the vectors and interleaves the resulting lanes.
  • PairwiseAdd128 adds consecutive pairs of elements in each of the vectors and then packs the results in 128 bit blocks, such that the results of vector a are in the lower half of the block and the results of vector b are in the upper half of the block.
  • PairwiseSub128 subtracts consecutive pairs of elements in each of the vectors and then packs the results in 128 bit blocks, such that the results of vector a are in the lower half of the block and the results of vector b are in the upper half of the block.

Tests have been added for the operations.

The instruction matrix in g3doc/instruction_matrix.pdf may need to be updated, but it appears to have been generated manually.

@mazimkhan mazimkhan force-pushed the master branch 2 times, most recently from 4eb5a84 to d77be29 Compare November 18, 2024 17:17
dependabot bot and others added 25 commits November 19, 2024 13:24
@dependabot
Bump step-security/harden-runner from 2.10.1 to 2.10.2
bea0da5 
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.10.1 to 2.10.2.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@91182cc...0080882)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@copybara-github
Merge pull request google#2381 from google:dependabot/github_actions/…
5c7a693 
…step-security/harden-runner-2.10.2

PiperOrigin-RevId: 697981775
@Mousius
Revert to previous logic for GatherIndexN
3da3328
@jan-wassenberg @copybara-github
detect cache parameters
3cb3a91 
PiperOrigin-RevId: 698357330
@jan-wassenberg @copybara-github
replace non-test/trace fprintf with new hwy::Warn/HWY_WARN
8a0602d 
PiperOrigin-RevId: 698416280
@jan-wassenberg @copybara-github
topology fixes for M3
89b2678 
PiperOrigin-RevId: 698685120
@jan-wassenberg @copybara-github
Add topology support for Windows and Apple
d22ccd0 
Also reduce #if in mainline by factoring into helper functions, share code between Linux and FreeBSD
Use anon namespace instead of static

PiperOrigin-RevId: 699906189
@jan-wassenberg @copybara-github
add LSX/LASX targets. Refs google#2386
7e01a07 
PiperOrigin-RevId: 699936076
@copybara-github
Merge pull request google#2383 from Mousius:revert-gatherindexn
2b565e8 
PiperOrigin-RevId: 699943134
@ZequanWu @copybara-github
Remove VQSORT_SKIP workaround for compiler bug
02253c8 
The test passes with the most recent clang.

PiperOrigin-RevId: 700385250
@jan-wassenberg @copybara-github
Add BitsFromMask, promoting from detail::.
68b0fde 
Also split mask_test into mask_set_test,
remove unused overload in scalar,
modernize overloads (SFINAE instead of type tags).

PiperOrigin-RevId: 700701299
@jan-wassenberg @copybara-github
Add BitsFromMask, promoting from detail::.
bcf564e 
Also split mask_test into mask_set_test,
remove unused overload in scalar,
modernize overloads (SFINAE instead of type tags).

PiperOrigin-RevId: 700938851
@johnplatts
Added AVX10_2 and AVX10_2_512 targets
9b39ef2
@copybara-github
Merge pull request google#2395 from johnplatts:hwy_avx10_120124
b13a46f 
PiperOrigin-RevId: 701876987
@jan-wassenberg @copybara-github
(v2 of) Add BitsFromMask, promoting from detail::.
62c0a79 
Provide DFromM on all targets except SVE/RVV.
Also split mask_test into mask_set_test,
remove unused overload in scalar,
modernize overloads (SFINAE instead of type tags).
arm_sve required moving some sections earlier before their first usage.

PiperOrigin-RevId: 701919058
@johnplatts
Fix for RVV CMake detection if cross-compiling with Clang
07396f9
@johnplatts
Made changes to RVV Concat, Combine, ZeroExtendVector, and UpperHalf ops
914cb69
@copybara-github
Merge pull request google#2396 from johnplatts:hwy_rvv_cmake_fix_120224
9689e2c 
PiperOrigin-RevId: 702035129
@johnplatts
Enable tuples on RVV with Clang 17 or later
80839b5
@copybara-github
Merge pull request google#2397 from johnplatts:hwy_rvv_tuple_120224
fca5363 
PiperOrigin-RevId: 702229080
@dependabot
Bump actions/cache from 4.0.2 to 4.2.0
fccc82d 
Bumps [actions/cache](https://github.com/actions/cache) from 4.0.2 to 4.2.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@0c45773...1bd1e32)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@copybara-github
Merge pull request google#2401 from google:dependabot/github_actions/…
b9fa960 
…actions/cache-4.2.0

PiperOrigin-RevId: 703468488
@jan-wassenberg @copybara-github
add perf_counters
83b81ab 
PiperOrigin-RevId: 705134221
@jan-wassenberg @copybara-github
fix topology detection for some CPUs being offline (e.g. SMT off)
a076ade 
PiperOrigin-RevId: 705569288
@johnplatts
Fixes for ZSeries with GCC 9 or earlier or Clang 18 or earlier
eb4dc59
johnplatts and others added 28 commits January 31, 2025 07:47
@johnplatts
Added GetBiasedExponent op and AVX3 implementation of GetExponent
45a3804
@copybara-github
Merge pull request google#2453 from cambridgeconsultants:cc_up_LoadMa…
140f307 
…skBits_optimisation

PiperOrigin-RevId: 721750804
@copybara-github
Merge pull request google#2458 from johnplatts:hwy_get_exp_enh_013125
e99df68 
PiperOrigin-RevId: 721763477
@mazimkhan @wbb-ccl
Various masked operations
c7e20c8
@wbb-ccl
Fix review comments
3c3fc48 
Remove OrZero suffix and fix MaskedOr docs
Update naming of masked table lookups to follow convention
Optimise MaskedReduceMin/Max
Add TODOs
Remove the masked table lookups
To be added alongside the platform specialisations
Remove unused macros
Rename HWY_SVE_RETV_ARGMVVZ to follow convention
@wbb-ccl
Fix bool_lanes typing
4702505
@wbb-ccl
Fix MaskedReduceMin/Max for floating point values
61552ba
@wbb-ccl
Fix rebase issue
af4183d
@mazimkhan @wbb-ccl
Zero masked arithmetic operations
046dee2
@wbb-ccl
Fix review comments
329e50a 
Remove OrZero suffixes for consistency
Rename MaskedDIvide for consistency
Rename HWY_SVE_RETV_ARGMVVZ etc. for consistency
Undef all new macros at end of file
Remove unused macro
Remove unnecessary wrapper functions
Remove MulLower, the rest of this implementation is in google#2429
Remove docs for ops not in this branch
Add missing MaskedMax op
Consolidate MulAdd tests
@wbb-ccl
Fix bool_lanes typing
2ed7aab
@wbb-ccl
Remove unused code
5c590e9
@wbb-ccl
Fix broken rebase
2fbf397
@wbb-ccl
Correct missing doc args
b4c66f7
@wbb-ccl
Add SVE2 implementation of SatWidenMulPairwiseAccumulate
4f0da39
@copybara-github
Merge pull request google#2459 from cambridgeconsultants:cc_up_SatWid…
f129551 
…enMulPairwiseAccumulate

PiperOrigin-RevId: 722975326
@copybara-github
Merge pull request google#2428 from cambridgeconsultants:cc_up_masked…
326dba3 
…_ops

PiperOrigin-RevId: 722985349
@wbb-ccl
Rename variable to avoid shadowing
3df6b16
@copybara-github
Merge pull request google#2426 from cambridgeconsultants:cc_up_masked…
4afbd48 
…_arithmetic

PiperOrigin-RevId: 723500133
@mazimkhan @wbb-ccl
AddLower, PairwiseAdd/Sub and MaskedAbsOr operations
b47886f
@mazimkhan @wbb-ccl
Add quick reference for MaskedAbsOr(Zero)
b926f4c
@wbb-ccl
Fix review comments
6631054 
Remove AddLower, MaskedAddOr can be used instead
Rename MaskedAbsOrZero and reorder MaskedAbsOr args
@wbb-ccl @johnplatts
Improved PairwiseAdd128/PairwiseSub128
0eb5670 
Co-authored-by: John Platts <[email protected]>
@johnplatts @wbb-ccl
Made additional changes to PairwiseAdd128/PairwiseSub128
5f6f5fc
@johnplatts @wbb-ccl
Fixed error with PairwiseAdd128/PairwiseSub128 on SSE2 target
e6ab8d7
@johnplatts @wbb-ccl
Fixed compiler warning in TestPairwiseAdd128 and TestPairwiseSub128
6b1e20d
@johnplatts @wbb-ccl
Fixed compiler warning in TestPairwiseAdd and TestPairwiseSub
74d5897
@wbb-ccl
Move PairwiseAdd/Sub128 to blockwise
f2b6329
wbb-ccl pushed a commit that referenced this pull request Feb 11, 2025
@ym38cho
Merge pull request #1 from google/master
b76001d 
sync latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.