-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): retains group toggle open status #790
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9c5f65e
fix(app): retains group toggle open status
shu20031026 432e177
fix(app): fix changeset
shu20031026 f093214
fix(app): use optional chain
shu20031026 ad1f7bd
fix(app): use existing state
shu20031026 cd04de3
fix(app): use existing state
shu20031026 f258f10
fix(app): fix functions in toggle hooks
shu20031026 c9534f0
Merge branch 'develop' of github.com:cam-inc/viron into retains-group…
shu20031026 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@viron/app": minor | ||
--- | ||
|
||
retains group toggle open status |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,7 @@ import { | |
useEndpointListUngroupedGlobalStateValue, | ||
useEndpointGroupListGlobalStateSet, | ||
useEndpointGroupListSortedGlobalStateValue, | ||
useEndpointGroupToggleState, | ||
} from '~/store'; | ||
import { | ||
Endpoint, | ||
|
@@ -922,3 +923,28 @@ export const useEndpoint = (): UseEndpointReturn => { | |
); | ||
return ret; | ||
}; | ||
|
||
export const useEndpointGroupToggle = (id: string) => { | ||
const [endpointGroups, setEndpointGroups] = useEndpointGroupToggleState(); | ||
|
||
const isOpenToggle = | ||
endpointGroups.find((group) => group.id === id)?.isOpenToggle ?? false; | ||
|
||
const setIsOpenToggle = () => { | ||
setEndpointGroups((groups) => { | ||
const index = groups.findIndex((group) => group.id === id); | ||
|
||
if (index === -1) { | ||
return groups; | ||
} | ||
|
||
return groups.map((group, i) => | ||
i === index | ||
? { ...group, isOpenToggle: group.isOpenToggle !== true } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps just using "!" operator would be sufficient to evaluate it. isOpenToggle: !group.isOpenToggle |
||
: group | ||
); | ||
}); | ||
}; | ||
|
||
return { isOpenToggle, setIsOpenToggle }; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,3 +102,6 @@ export const useEndpointGroupListItemGlobalStateValue = ( | |
export const useEndpointGroupListItemGlobalStateSet = ( | ||
params: Parameters<typeof endpointGroupListItemSelector>[0] | ||
) => useGlobalStateSet(endpointGroupListItemSelector(params)); | ||
|
||
export const useEndpointGroupToggleState = () => | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you change this to useEndpointGroupListGlobalState? |
||
useGlobalState(endpointGroupListAtom); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functions that start with "set" are typically considered as setters for private properties. Nonetheless, the absence of arguments in such a function could make its behavior unpredictable.