fix(app): retains group toggle open status #790
Conversation
🦋 Changeset detectedLatest commit: c9534f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/app/src/hooks/endpoint.ts
Outdated
| const [endpointGroups, setEndpointGroups] = useEndpointGroupToggleState(); | ||
|
|
||
| const endpointGroup = endpointGroups.find((group) => group.id === id); | ||
| const isOpenToggle = endpointGroup |
There was a problem hiding this comment.
Perhaps using optional chaining will improve readability, instead of using the ternary operator.
packages/app/src/hooks/endpoint.ts
Outdated
|
|
||
| return groups.map((group, i) => | ||
| i === index | ||
| ? { ...group, isOpenToggle: group.isOpenToggle !== true } |
There was a problem hiding this comment.
Perhaps just using "!" operator would be sufficient to evaluate it.
isOpenToggle: !group.isOpenToggle
packages/app/src/hooks/endpoint.ts
Outdated
| const isOpenToggle = | ||
| endpointGroups.find((group) => group.id === id)?.isOpenToggle ?? false; | ||
|
|
||
| const setIsOpenToggle = () => { |
There was a problem hiding this comment.
Functions that start with "set" are typically considered as setters for private properties. Nonetheless, the absence of arguments in such a function could make its behavior unpredictable.
packages/app/src/store/index.ts
Outdated
| @@ -102,3 +102,6 @@ export const useEndpointGroupListItemGlobalStateValue = ( | |||
| export const useEndpointGroupListItemGlobalStateSet = ( | |||
| params: Parameters<typeof endpointGroupListItemSelector>[0] | |||
| ) => useGlobalStateSet(endpointGroupListItemSelector(params)); | |||
|
|
|||
| export const useEndpointGroupToggleState = () => | |||
There was a problem hiding this comment.
Could you change this to useEndpointGroupListGlobalState?
Summary
It is now possible to maintain the open/closed state of group toggles using local storage.
Checklist