Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new section for point time locked contract (PTLC) #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add new section for point time locked contract (PTLC) #2

wants to merge 1 commit into from
+16 −0

Conversation

calvinrzachman
Copy link
Owner

No description provided.

@calvinrzachman calvinrzachman self-assigned this Apr 19, 2021
calvinrzachman
calvinrzachman commented Apr 19, 2021
View reviewed changes
Copy link
Owner Author

@calvinrzachman calvinrzachman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start to me. Save the detail for a future PR!

lightning-network/point-time-locked-contract/README.md

### Absolute Timelocks

- CHECKLOCKTIMEVERIFY (CLTV)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to include a description of this!!

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

calvinrzachman
calvinrzachman commented Apr 19, 2021
View reviewed changes
Copy link
Owner Author

@calvinrzachman calvinrzachman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header comment

lightning-network/point-time-locked-contract/README.md
# Point Time Locked Contracts (PTLC)


## Adaptor Signatures/One-Time Verifiably Encrypted Signatures (VES)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

calvinrzachman
calvinrzachman commented Apr 19, 2021
View reviewed changes
Copy link
Owner Author

@calvinrzachman calvinrzachman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a review where I left a comment and a reply to someone else's comment.

lightning-network/point-time-locked-contract/README.md

## Adaptor Signatures/One-Time Verifiably Encrypted Signatures (VES)

## Timelocks in Bitcoin
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up?

lightning-network/point-time-locked-contract/README.md

### Absolute Timelocks

- CHECKLOCKTIMEVERIFY (CLTV)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

calvinrzachman
calvinrzachman commented Apr 19, 2021
View reviewed changes
lightning-network/point-time-locked-contract/README.md

#### Transaction vs. Script Level Locking

### Relative Timelocks
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my best review comment ever!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@calvinrzachman calvinrzachman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@calvinrzachman