Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer rewrite/encoding #74

Closed
wants to merge 3 commits into from
Closed

Buffer rewrite/encoding #74

wants to merge 3 commits into from

Conversation

calvinmetcalf
Copy link
Owner

@calvinmetcalf calvinmetcalf commented Mar 24, 2017

for use in tandem with calvinmetcalf/parseDBF#10

@calvinmetcalf
Copy link
Owner Author

this change brings the size from 60KB to 234KB, almost all of that is for non utf8 encodings

@calvinmetcalf
Copy link
Owner Author

actually more like 260k, and 200k is from iconv lite

@calvinmetcalf
Copy link
Owner Author

calvinmetcalf commented Mar 28, 2017

gzipped and minified sizes for various options, in bytes

Option Size
original 59,172
just utf8 60,363
IE needs a shim for non-utf8 65,676
all encodings 236,209

@calvinmetcalf
Copy link
Owner Author

ok if we use the polyfill and require IE users who want other encodings to include a file then we can do it in 65676 bytes, though it's waiting on inexorabletash/text-encoding#70

@calvinmetcalf
Copy link
Owner Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant