Dialogxml fixes/notes/updates #575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NQNStudios
force-pushed
the
dialogxml
branch
from
bd1762c to
6456647
Compare
|
Saying it here so I don't forget: I have a few changes to specific dialogs pending, which I'd like to get in before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have 4 help windows in the scenario editor that are very outdated (including #495) -- I added a cautionary dialog that warns the user the info is outdated and has the URL for openboe.com. (This is temporary and these will eventually probably call launchDocs instead of opening a help dialog at all.)
I fixed up the Hints dialog in the main game so it's up-to-date.
I removed an out-of-date Exile 3 reference from help-inventory and a TODO comment that's not relevant anymore because we do have a JOBS button.
Went through and exhaustively added a note about which dialogxmls should eventually get relative positioning if we ever need to change them. This marks the work that would be required for #300, which is not necessarily worth actually doing for the many many dialogs that just might stay the same forever.