Skip to content

fix(banner): make hidden content inert and fix live region semantics #5056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukemorawski wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix(banner): make hidden content inert and fix live region semantics #5056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
92db121
fix: make hidden banner content inert and fix region semantics
lukemorawski Aug 18, 2026
47d5ad0
fix: call show/hide animation callbacks only on animation finished
lukemorawski Aug 19, 2026
ce774c7
fix: announce banner on every show and stop focus restore crashing web
lukemorawski Aug 20, 2026
f53e74d
fix: keep a touchableRef passed through an action
lukemorawski Aug 20, 2026
e7cd1d8
refactor: drop the type casts flagged in review
lukemorawski Aug 20, 2026
5181930
refactor: drop the as any casts from the animation mocks
lukemorawski Aug 20, 2026
c5eb8d5
fix: reflow actions on measured width instead of flex wrap
lukemorawski Aug 21, 2026
d347dc3
fix: address review on test ids, focus, action refs and icon role
lukemorawski Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions example/src/Examples/BannerExample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const PHOTOS = Array.from({ length: 24 }).map(
const BannerExample = () => {
const [visible, setVisible] = React.useState<boolean>(true);
const [useCustomTheme, setUseCustomTheme] = React.useState<boolean>(false);
const [urgent, setUrgent] = React.useState<boolean>(false);
const defaultTheme = useTheme();

const [height, setHeight] = React.useState(0);
Expand Down Expand Up @@ -52,8 +53,14 @@ const BannerExample = () => {
</View>
</ScreenWrapper>
<FAB icon="eye" style={styles.fab} onPress={() => setVisible(!visible)} />
<FAB
icon="alert"
style={styles.urgentFab}
onPress={() => setUrgent(!urgent)}
/>
<Banner
onLayout={handleLayout}
urgent={urgent}
actions={[
{
label: `Set ${useCustomTheme ? 'default' : 'custom'} theme`,
Expand All @@ -75,8 +82,9 @@ const BannerExample = () => {
theme={useCustomTheme ? customTheme : defaultTheme}
style={styles.banner}
>
Two line text string with two actions. One to two lines is preferable on
mobile.
{urgent
? 'Urgent: this message interrupts the screen reader.'
: 'Two line text string with two actions. One to two lines is preferable on mobile.'}
</Banner>
</>
);
Expand Down Expand Up @@ -128,6 +136,12 @@ const styles = StyleSheet.create({
bottom: 0,
margin: 16,
},
urgentFab: {
alignSelf: 'flex-end',
position: 'absolute',
bottom: 0,
margin: 16,
},
});

export default BannerExample;
Loading