[feat] add local iOS SPM package output#358
Draft
adamTrz wants to merge 3 commits into
Draft
Conversation
6418700 to
d3f3898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--add-spm-packagetobrownfield package:iosto generate a local Swift Package alongside the packaged XCFrameworksPackage.swiftandREADME.mdfor the local package, including Hermes, ReactBrownfield, Brownie, BrownfieldNavigation, React, and ReactNativeDependencies when presentWhy
We want an incremental path toward Swift Package Manager consumption of packaged RN iOS artifacts before the wider RN core migration lands.
Validation
yarn workspace @callstack/brownfield-cli lintyarn workspace @callstack/brownfield-cli typecheckyarn workspace @callstack/brownfield-cli testapps/RNApp, added it toAppleAppin Xcode, and confirmed the app runs without MetroNotes
AppleAppstays on the existing integration setup in-repo