refactor: restructure oasdiff ignore file for transparency and auditability#28798
refactor: restructure oasdiff ignore file for transparency and auditability#28798CodeBySayak wants to merge 1 commit intocalcom:mainfrom
Conversation
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
📝 WalkthroughWalkthroughThis change modifies the ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
.github/oasdiff-err-ignore.txt (2)
526-530: Consider moving Authorization-header entries to “Verified Safe” (spec alignment).These appear to document already-enforced auth behavior rather than a new runtime break, so leaving them under “Potentially Breaking” may dilute high-risk triage signal.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/oasdiff-err-ignore.txt around lines 526 - 530, Relocate the two Authorization-header entries for the endpoints GET /v2/bookings/{bookingUid}/recordings and GET /v2/bookings/{bookingUid}/transcripts from the “Potentially Breaking” list into the “Verified Safe” (or equivalent) section in the oasdiff ignore listing; update the classification text to note these reflect already-enforced auth behavior rather than a new runtime change so they won’t dilute the high-risk triage signal.
542-545: Avoid leaving items in “Uncategorized.”To keep backlog auditing actionable, assign these two entries to an explicit risk bucket (safe vs needs review) and add a brief rationale like other sections.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/oasdiff-err-ignore.txt around lines 542 - 545, Two API change entries are left in the "Uncategorized" section; assign each one to an explicit risk bucket and add a short rationale. Move the lines for "GET /v2/organizations/{orgId}/teams/{teamId}/conferencing/{app}/oauth/auth-url" and "GET /v2/organizations/{orgId}/teams/{teamId}/stripe/connect" out of Uncategorized into either the "Safe" or "Needs review" section, and append a one-sentence rationale explaining the impact of the orgId path parameter type change (string -> number) and why you chose that risk level.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/oasdiff-err-ignore.txt:
- Around line 526-530: Relocate the two Authorization-header entries for the
endpoints GET /v2/bookings/{bookingUid}/recordings and GET
/v2/bookings/{bookingUid}/transcripts from the “Potentially Breaking” list into
the “Verified Safe” (or equivalent) section in the oasdiff ignore listing;
update the classification text to note these reflect already-enforced auth
behavior rather than a new runtime change so they won’t dilute the high-risk
triage signal.
- Around line 542-545: Two API change entries are left in the "Uncategorized"
section; assign each one to an explicit risk bucket and add a short rationale.
Move the lines for "GET
/v2/organizations/{orgId}/teams/{teamId}/conferencing/{app}/oauth/auth-url" and
"GET /v2/organizations/{orgId}/teams/{teamId}/stripe/connect" out of
Uncategorized into either the "Safe" or "Needs review" section, and append a
one-sentence rationale explaining the impact of the orgId path parameter type
change (string -> number) and why you chose that risk level.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 41899e53-b324-4f7e-bfbb-fd537e2ccdd1
📒 Files selected for processing (1)
.github/oasdiff-err-ignore.txt
|
Hi! All changes are ready and checks should pass. |
Summary
Restructured
.github/oasdiff-err-ignore.txtinto a clear, categorized triage system to improve transparency and make backlog auditing actionable.Problem
The ignore file had grown into a 500+ line flat list of suppressed changes, making it:
Solution
Reorganized the file into well-defined sections with context and prioritization:
1. Verified Safe Changes / Intentional Refactors
oneOfadditions, path parameter corrections)2. Potentially Breaking / Needs Review
3. Contextual Annotations
Impact
Additional Context
git addcompleted)Follow-up / Roadmap
api_migration_strategy.md)fixes #28754
Mandatory Tasks (DO NOT REMOVE)