fix: preserve array query parameters during dynamic group redirect#28789
Draft
jaydeep-pipaliya wants to merge 1 commit intocalcom:mainfrom
Draft
fix: preserve array query parameters during dynamic group redirect#28789jaydeep-pipaliya wants to merge 1 commit intocalcom:mainfrom
jaydeep-pipaliya wants to merge 1 commit intocalcom:mainfrom
Conversation
When context.query contains array values (e.g., user=john&user=doe), casting to Record<string, string> and passing to URLSearchParams incorrectly serializes them as user=john,doe. Fix by iterating entries and using URLSearchParams.append() per value to preserve multiple values for the same key. Fixes calcom#28687
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #28687
When a URL contains repeated query parameters (e.g.,
/john?user=john&user=doe), Next.js parses them asstring[]. Passingcontext.querycast toRecord<string, string>intoURLSearchParamsserializes arrays as comma-separated strings (user=john%2Cdoe), breaking downstream logic.Fix
Replace the cast with explicit iteration using
URLSearchParams.append()per value:Changes
apps/web/server/lib/[user]/getServerSideProps.ts— fix query string serialization in dynamic group redirect