fix(weekly-view): correct time slot offset and clipped slots#28786
fix(weekly-view): correct time slot offset and clipped slots#28786Akhilesh-Varute wants to merge 2 commits intocalcom:mainfrom
Conversation
- Fix SchedulerColumns marginTop fallback from var(--gridDefaultSize) (58px) to var(--calendar-offset-top) (28px) so the event grid aligns correctly with time labels on first render - Fix falsy check for topOffsetMinutes === 0 in Cell and CustomCell so slots at the start hour are correctly positioned with absolute + top: 0 Fixes calcom#14208
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request updates CSS positioning logic in the calendar weekly view components. In the event component, truthiness checks for 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi, could a maintainer please add the run-ci label so CI checks can run? Thanks! |
romitg2
left a comment
There was a problem hiding this comment.
please add before/after image/video demo


What does this PR do?
Fixes two layout bugs in the weekly calendar view.
SchedulerColumnsmarginTopfallback fromvar(--gridDefaultSize)(58px) tovar(--calendar-offset-top)(28px) so the event grid aligns correctly with time labels on first rendertopOffsetMinutes === 0inCellandCustomCellso slots at the start hour are correctly positioned withabsolute+top: 0Fixes #14208
Visual Demo
Before: Time slots are offset from the time labels on the left, and end-hour slots get clipped (as shown in the issue screenshots).
After: Slots align correctly with time labels and no slots are clipped.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
/alan)No environment variables needed. A standard cal.com local setup is sufficient.