fix: require state verification on all app installs#28781
Draft
pedroccastro wants to merge 1 commit intomainfrom
Draft
fix: require state verification on all app installs#28781pedroccastro wants to merge 1 commit intomainfrom
pedroccastro wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the nonce exemption for basecamp3, webex, and tandem OAuth integrations. All app installs now require state parameter verification via HMAC nonce, consistent with other integrations.
Changes
NONCE_EXEMPT_APPSallowlist fromdecodeOAuthStateappSlugparameter fromdecodeOAuthStateencodeOAuthStateto basecamp3, webex, and tandem/addhandlersdecodeOAuthState+ auth checks to the top of callbacks (before token exchange and DB writes)How should this be tested?
Automated
Manual
Mandatory Tasks