-
Notifications
You must be signed in to change notification settings - Fork 11.2k
fix: exclude AWAITING_HOST from seed-insights random status selection #25414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: exclude AWAITING_HOST from seed-insights random status selection #25414
Conversation
AWAITING_HOST status requires special handling for instant meetings: - userId must be NULL (not assigned until host joins) - Requires InstantMeetingToken to be created - Only used for actual instant meetings via InstantBookingCreateService This fix prevents the seed script from creating invalid test data where AWAITING_HOST bookings have a userId assigned, which doesn't match production behavior. Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
More maintainable approach - if new statuses are added in the future, they will automatically be included in seed data generation. Co-Authored-By: [email protected] <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Calculate the filtered statuses once at module load instead of on every shuffle call for better performance. Co-Authored-By: [email protected] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
E2E results are ready! |
What does this PR do?
Fixes a bug in the seed-insights script where
AWAITING_HOSTstatus was randomly assigned to bookings along with auserId, which violates the correct behavior of instant meetings.Problem:
AWAITING_HOST)AWAITING_HOSTwas selected, the script still assigned auserIdAWAITING_HOSTstatus should haveuserId = NULLuntil a host joinsSolution:
AWAITING_HOSTfromBookingStatusvalues usingObject.values(BookingStatus).filter()validStatusesForSeedto module level so it's calculated once at load time instead of on every shuffle callMandatory Tasks (DO NOT REMOVE)
How should this be tested?
yarn seed-insightsAWAITING_HOSTbookings are created with auserId:Checklist