[chore] address feedback for onboarding #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r limit to availability desc, add comment for legal credential
varortz
reviewed
May 24, 2024
There was a problem hiding this comment.
Hey Jinkang, huge thank you for making these updates based on the feedback we received! Just added a couple comments, and I think it should be good to merge after we've addressed these :) Also, here are some additional things I noticed while reviewing:
Onboarding Review Page:
- Availability Section Overflow - could we add
overflow-wrap: break-word;to this text (similar to how we did with the summary for listings) to address this edge case:
- Roles Section -
- It seems like for attorneys, we're missing the additional information field. Could we go ahead and include this while also making sure it has the
overflow-wrap: break-word;property? - Could we also go ahead and update "Legal Experience" to "Legal Credentials" for both attorneys and legal fellows.
- It seems like for attorneys, we're missing the additional information field. Could we go ahead and include this while also making sure it has the
Settings
- Same as above, could we add the
overflow-wrap: break-word;property to both the Roles and Availability section in the settings page?
varortz
approved these changes
May 24, 2024
| @@ -28,6 +29,7 @@ export interface ProfileToUpload | |||
| | 'eoir_registered' | |||
| | 'bar_number' | |||
| | 'legal_credential_comment' | |||
| | 'has_bar_number' | |||
There was a problem hiding this comment.
ty for adding this to the schema + supabase!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎋 Description
🌴 What's new in this PR
🌲 Screenshots
No bar number
Has bar number
🌳 How to review
Go in any order
CC: @varortz