Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] implement conditional routing from Volunteer Now #82

Merged
merged 10 commits into from
May 8, 2024
Merged

[feat] implement conditional routing from Volunteer Now #82

merged 10 commits into from
May 8, 2024

Conversation

ccatherinetan
Copy link
Contributor

@ccatherinetan ccatherinetan commented May 1, 2024 •
edited
Loading

🎋 Description

🌴 What's new in this PR

  • implements conditional routing from Volunteer Now button on home page.
  • implements conditional routing in login
    • (an already logged in user will be redirected to settings)
    • routing to listing page / onboarding after logging in

routing logic

  • if not signed in → Log in
  • if not onboarded → Onboarding
  • if Attorney (or Attorney + Interpreter) → Cases
  • If Legal Fellow (or Legal Fellow + Interpreter) → LCA page
  • else (if Interpreter only) → Language Support

🌲 Screenshots

🌳 How to review

check app/page

🌱 Next steps

🔗 Relevant Links

ℹ️ Online sources

🪴 Related PRs

CC: @varortz

@linear Linear
Copy link

linear bot commented May 1, 2024

IJP-131 Finish implementing the home page

jinkang-0
jinkang-0 reviewed May 4, 2024
View reviewed changes
src/app/(auth)/login/page.tsx Outdated Show resolved Hide resolved
src/app/(auth)/login/page.tsx Outdated Show resolved Hide resolved
varortz
varortz reviewed May 6, 2024
View reviewed changes
src/app/page.tsx Outdated Show resolved Hide resolved
src/app/(auth)/login/page.tsx Outdated Show resolved Hide resolved
@ccatherinetan ccatherinetan force-pushed the catherine/ijp-131-finish-implementing-the-home-page branch from 63a1e96 to 9e0ce71 Compare May 7, 2024 23:29
jinkang-0
jinkang-0 reviewed May 8, 2024
View reviewed changes
src/app/(auth)/login/page.tsx Outdated Show resolved Hide resolved
src/app/(auth)/login/page.tsx Outdated Show resolved Hide resolved
jinkang-0
jinkang-0 approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@jinkang-0 jinkang-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@varortz varortz merged commit 86c4d15 into main May 8, 2024
2 checks passed
@varortz varortz mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varortz varortz varortz approved these changes

@jinkang-0 jinkang-0 jinkang-0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccatherinetan @jinkang-0 @varortz