Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] update listing pages to match design #75

Merged

Conversation

jinkang-0
Copy link
Contributor

@jinkang-0 jinkang-0 commented Apr 10, 2024

🎋 Description

🌴 What's new in this PR

What's new:

  • Modified all listing pages (cases, LCA, language support) to match design
    • Added respective filters
  • Added custom scrollbars to listings page + dropdown menus
  • Now updates selected card when filters change
  • Tweaked filtering to not filter out NULL values (but sort them to the end)

🌲 Screenshots

Cases

image

LCA

image

Language Support

image

🌳 How to review

First get this branch onto your local machine

# fetch from github, only necessary for first time review
git fetch origin ijp-129-update-listing-pages-to-match-design

# checkout to the branch
git checkout ijp-129-update-listing-pages-to-match-design

# pull updates, skip for first time review
git pull origin ijp-129-update-listing-pages-to-match-design

For future reviews if you fetched to local machine before this has rebased:

# toss uncommitted changes
# CAUTION: only do this if you're absolutely SURE you're on this branch
# double check: jinkang/ijp-129-update-listing-pages-to-match-design
git reset --hard

# delete this branch
git checkout main
git branch -D ijp-129-update-listing-pages-to-match-design

# redo setup
git fetch origin ijp-129-update-listing-pages-to-match-design
git checkout ijp-129-update-listing-pages-to-match-design
git pull origin ijp-129-update-listing-pages-to-match-design

Start the server

npm run dev

Code Review (recommended order):

  • @/components/ListingPage/
  • @/app/cases/
  • @/app/limited-case-assignments/
  • @/app/language-support/

🌱 Next steps

🔗 Relevant Links

ℹ️ Online sources

Very helpful scrollbar gist: https://gist.github.com/spemer/a0e218bbb45433bd611e68446523a00b

🪴 Related PRs

CC: @varortz, @kyrenetam

Copy link

linear bot commented Apr 10, 2024

@jinkang-0 jinkang-0 marked this pull request as draft April 10, 2024 06:16
@varortz varortz requested review from varortz and rahihazra April 11, 2024 18:30
@varortz varortz requested a review from kevin3656 April 14, 2024 08:25
@jinkang-0 jinkang-0 force-pushed the jinkang/ijp-129-update-listing-pages-to-match-design branch from 3443ad8 to 8bd60a0 Compare April 16, 2024 07:56
@jinkang-0 jinkang-0 marked this pull request as ready for review April 16, 2024 08:34
src/app/limited-case-assignments/page.tsx Outdated Show resolved Hide resolved
src/app/cases/page.tsx Outdated Show resolved Hide resolved
src/components/ListingDetails/styles.ts Show resolved Hide resolved
src/components/ListingPage/styles.ts Show resolved Hide resolved
@varortz varortz removed the request for review from rahihazra April 23, 2024 18:11
@jinkang-0 jinkang-0 force-pushed the jinkang/ijp-129-update-listing-pages-to-match-design branch from 50cb151 to 37a26a8 Compare April 24, 2024 01:28
Copy link
Contributor

@ccatherinetan ccatherinetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you set a filter and the case currently displayed in the ListingDetails section is not included in that filter group, we do not swap the ListingDetails to the first item of the filtered group. Is this the intended behavior?

@jinkang-0 jinkang-0 force-pushed the jinkang/ijp-129-update-listing-pages-to-match-design branch from 6d0469c to 64b521e Compare May 1, 2024 20:41
src/components/ProfileMatch/index.tsx Outdated Show resolved Hide resolved
src/components/ListingDetails/index.tsx Outdated Show resolved Hide resolved
src/components/ListingDetails/styles.ts Outdated Show resolved Hide resolved
src/components/ListingPage/styles.ts Show resolved Hide resolved
Copy link
Collaborator

@varortz varortz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@ccatherinetan ccatherinetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ccatherinetan ccatherinetan merged commit 65c3553 into main May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants