-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] update listing pages to match design #75
[refactor] update listing pages to match design #75
Conversation
3443ad8
to
8bd60a0
Compare
50cb151
to
37a26a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you set a filter and the case currently displayed in the ListingDetails section is not included in that filter group, we do not swap the ListingDetails to the first item of the filtered group. Is this the intended behavior?
6d0469c
to
64b521e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
🎋 Description
🌴 What's new in this PR
What's new:
NULL
values (but sort them to the end)🌲 Screenshots
Cases
LCA
Language Support
🌳 How to review
First get this branch onto your local machine
For future reviews if you fetched to local machine before this has rebased:
Start the server
Code Review (recommended order):
@/components/ListingPage/
@/app/cases/
@/app/limited-case-assignments/
@/app/language-support/
🌱 Next steps
🔗 Relevant Links
ℹ️ Online sources
Very helpful scrollbar gist: https://gist.github.com/spemer/a0e218bbb45433bd611e68446523a00b
🪴 Related PRs
CC: @varortz, @kyrenetam