[feat] make progress bar component #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IJP-69 Make progress bar component.
Screenshot 2023-10-31 at 9.57.20 PM.png Screenshot 2023-10-31 at 9.57.39 PM.png Make the progress bar component according to the hifis for the onboarding flows. There are different versions for this for the attorney and interpreter flows— please reference the Figma to figure out what these options look like! [bar count +1] |
jinkang-0
force-pushed
the
jinkang/ijp-69-make-progress-bar-component
branch
from
2b56aea to
ed2cf3e
Compare
| }) { | ||
| return ( | ||
| <ProgressCircleDiv $checked={checked}> | ||
| <H4>{text}</H4> |
There was a problem hiding this comment.
Question for @davidqing6432: Personally, I feel like it would be better to have the titles for each circle be slightly further away from the circle itself?
pragyakallanagoudar
approved these changes
Nov 16, 2023
davidqing6432
approved these changes
Nov 16, 2023
pragyakallanagoudar
deleted the
jinkang/ijp-69-make-progress-bar-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎋 Description
🌴 What's new in this PR
Added
ProgressBarcomponentRestructured auth flow to share layout with for general auth and for onboarding.
🌲 Screenshots
🌳 How to review
First, fetch this branch:
Then, git checkout
Finally, navigate to
localhost:3000/onboarding/after starting the server to see the changes.🌱 Next steps
🔗 Relevant Links
ℹ️ Online sources
🪴 Related PRs
CC: @pragyakallanagoudar, @davidqing6432