[refactor] update schema types (again) #29

jinkang-0 · 2023-10-30T05:07:48Z

🎋 Description

🌴 What's new in this PR

Modified src/types/schema.ts:

Updated existing types to reflect schema changes on drawSQL
Added miscellaneous types for table fields for specific enums and join tables

Updated the following pages to handle new type changes:

src/app/cases/page.tsx
src/app/create-profile/page.tsx
src/app/interest/page.tsx
src/app/profile/page.tsx

Updated the following components to handle new type changes:

src/components/ListingCard.tsx

Unplanned:

Modified queries in src/api/supabase/queries/ to have consistent error messages.
Updated comments in src/utils/helpers.ts

🌲 Screenshots

🌳 How to review

First review changes in types/schema.ts, then review in any order.

🌱 Next steps

🔗 Relevant Links

ℹ️ Online sources

🪴 Related PRs

CC: @pragyakallanagoudar

linear · 2023-10-30T05:07:51Z

IJP-59 update schema types (again)

Add new types corresponding to each table. Update existing type dependencies.

src/types/schema.ts

src/api/supabase/queries/cases.ts

src/types/schema.ts

varortz · 2023-11-08T09:38:52Z

src/types/schema.ts

+  country?: string;
+  client_location?: string;
+  legal_server_id: number;
+  hours_per_month?: number;


do we want hours_per_month to be optional? I think David added a tag on the case listing card component that corresponds to a case's anticipated hrs/month. Are we ok with not displaying that tag for all cards if some cases don't have that info, or should we make it required to show the hrs/month data for all case listing cards?

great point!! the hours per month is an additional field that is going to be added to LegalServer, and so there is the possibility of it being null if someone forgets to input it on LegalServer. generally we're making all LegalServer fields nullable because there's always the possibility of someone forgetting to fill them out on there.

@davidqing6432 wondering if you have ideas for modifications to the case listing card in the case that some of these fields are null?

pragyakallanagoudar · 2023-11-09T05:17:29Z

src/types/schema.ts

+// table field types
+export type ImmigrationLawExperienceEnum = 'LOW' | 'MEDIUM' | 'HIGH';
+
+export type AdjudicatingAgencyEnum =


Related to your message on Slack, what are your thoughts on making adjudicating agency a string instead of an enum? I think that might allow for more flexibility, in case they add another potential agency afterward

Yeah I think that makes sense given legal server data may not be standardized to fit into the enum

We should also note that we will be pulling experience_needed from legal server as well, and we may want to ask them about the format it'll be in

src/types/schema.ts

src/components/InterestForm/index.tsx

src/app/cases/page.tsx

pragyakallanagoudar

Looks fantastic, Jinkang! I have a couple of clarifying questions and comments on here, but largely this looks good to merge. THANK YOU SO MUCH FOR WORKING ON THIS

added schema changes

jinkang-0 marked this pull request as ready for review October 30, 2023 05:19

jinkang-0 marked this pull request as draft October 30, 2023 05:50

jinkang-0 marked this pull request as ready for review October 31, 2023 20:11