[chore] modify ESLint rules and resolve package vulnerabilities #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IJP-38 Resolve ESLint issues/complaints and update packages
Since we'll have to update ESLint issues to resolve:
|
pragyakallanagoudar
approved these changes
Oct 30, 2023
pragyakallanagoudar
deleted the
jinkang/ijp-38-resolve-eslint-issuescomplaints-and-update-packages
branch
ccatherinetan
pushed a commit
that referenced
this pull request
Nov 2, 2023
* resolved package vulnerabilities and eslint issues * updated no-console rules * include warn in console rule (oops)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎋 Description
🌴 What's new in this PR
Modified
.eslintrc.jsto include the new ESLint rules.Modified
package.jsonto allow npm to perform audit fix on next dependencies.🌲 Screenshots
End result
No red squigglies 😌
No vulnerabilities☺️
console.logbad,console.errorgood 👍🌳 How to review
Recommended to first fetch this branch with
Then switch to this branch with
To review, check whether or not Lint complains about labels not having an associated input (when it has an htmlFor property). Also test if it complaints when you only export one thing without doing
export default.Lastly, run
npm auditto see if there are any vulnerabilities. It should say 0 vulnerabilities.🌱 Next steps
🔗 Relevant Links
ℹ️ Online sources
🪴 Related PRs
CC: @pragyakallanagoudar