Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] Reorganize auth routes #42

Merged
merged 3 commits into from
Nov 29, 2023
Merged

[auth] Reorganize auth routes #42

merged 3 commits into from
Nov 29, 2023

Conversation

adityapawar1
Copy link
Collaborator

What's new in this PR

  • Reorganize the file structure so each auth route has its own folder and styles file
  • Does not change functionality

Relevant Links

None

Notion Sprint Task

Notion task

Online sources

None

Related PRs

None

How to review

  • Try navigating to each auth screen
  • Since sign up only work on a newer version of the app in another PR that hasn't been merged yet, I just tested navigating to sign up, login, and forgot password. Since I did the same thing for those three routes as I did for verify account and onboarding, I'm assuming that they should also work, but they have not been tested.

Next steps

None

Tests Performed, Edge Cases

  • Tested every auth screen except verify account and onboarding.

Screenshots

None

CC: @akshaynthakur

Copy link
Collaborator

@akshaynthakur akshaynthakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! We'll just wait until #35 is merged in so that we can fully test all of the routes properly.

@adityapawar1
Copy link
Collaborator Author

I think this should be ready to merge @akshaynthakur

@akshaynthakur akshaynthakur merged commit a76755f into main Nov 29, 2023
2 checks passed
@akshaynthakur akshaynthakur deleted the adi/auth-routes branch November 29, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants