Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grants frontend complete #36

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Grants frontend complete #36

wants to merge 27 commits into from

Conversation

varortz
Copy link
Collaborator

@varortz varortz commented Apr 15, 2023

🎉 What's new in this PR 🎉

☁️ ☁️ Description ☁️ ☁️

  • Revamped the GrantCard component to reflect the new fronted changes for grants
  • Completed the frontend for the GrantInfo screen
  • Added Icons for the amount and deadline fields
  • Added a placeholder image for all grant cards and the GrantInfo
  • Added a static button in the GrantInfo screen to view the full grant application in another browser
  • Added a static back button to exit a GrantInfo screen
  • 4/23 UPDATE: redid some of the implementation to try and follow best practices. Issue -> Images for GrantCard component do not fully fill the desired width.
  • Increased the opacity for the GrantCard component
  • 4/30 UPDATE: added Linking support for the View Application button and functionality to the back arrow button on the GrantInfo page

Screenshots 📲

image
image

⚡ How to review ⚡

  • Navigate to the grants newsfeed by clicking on the grant icon in the navbar
  • Scroll through the page and ensure everything looks consistent with the designs
  • Click on individual grants to get redirected to a 'GrantInfo' screen
  • Scroll through the 'GrantInfo' screen for a grant and ensure that everything is consistent with the designs

🌱 Next steps 🌱

  • Add navigation for the back button on the GrantInfo screen
  • Add support for uploading images to backend & displaying them on the app
  • Add functionality to the "View Application" button
  • Include a share grant feature which would share the grant's application
  • Implement a "new grant" notifier

Relevant Links 🔗

Online sources ℹ️

Related PRs 🙌

CC: @davidqing6432 @wangannie @leexesther

<View style={styles.imageContainer}>
<Image source={grantPlaceholder} style={styles.image} />
</View>
<RectButton
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rect button seems to automatically capitalize text, don't know if this should be a problem

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah you're right! I just used the RectButton that we've been using but I can make another button component if you want.

</Text>
</View>
<View style={styles.infoContainer2}>
<Text>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra wrapper, what is this for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one with styles.infoContainer2? That is for the grant fields (eligible countries, duration, and brief/description) since they require different styling compared to the amount + deadline fields.

Copy link
Collaborator

@davidqing6432 davidqing6432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

</Text>
</View>
<View style={styles.infoContainer2}>
<Text>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra wrapper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants