Miha/Kevin Audio Download/Delete #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* built app, added configuration, and queries demo as a screen. * removing unnecessary firebase env variable comments
…val-mobile into miha-kevin-audio-download
…eprint/cultural-survival-mobile into miha-kevin-audio-download
davidqing6432
approved these changes
Apr 24, 2023
src/firebase/AudioDemos.tsx
Outdated
| const audios = await downLoadAudio(audio_id); | ||
| const didItDownload = await getInfoAsync(audios); | ||
| // eslint-disable-next-line no-console | ||
| console.log(didItDownload); |
There was a problem hiding this comment.
isDownloaded instead
src/firebase/AudioDemos.tsx
Outdated
| console.log(didItDownload); | ||
|
|
||
| deleteAudio(audios); | ||
| const didItDelete = await getInfoAsync(audios); |
src/firebase/AudioDemos.tsx
Outdated
|
|
||
| export default function QueriesDemo() { | ||
| const [audio] = useState<Audio[]>([]); | ||
| // eslint-disable-next-line camelcase |
There was a problem hiding this comment.
change to camelcase
src/firebase/AudioDemos.tsx
Outdated
| import { Button, Text, TextInput, View } from 'react-native'; | ||
| import { getInfoAsync } from 'expo-file-system'; | ||
| import { Audio } from '../types/schema'; | ||
| // import { getAllAudio, getAudioID } from './queries/audioQueries'; |
src/firebase/AudioDemos.tsx
Outdated
There was a problem hiding this comment.
we shouldn't be using an audio demos file, move this elsewhere or delete the file
src/screens/PlayScreen/Play.tsx
Outdated
| console.log(didItDownload); | ||
|
|
||
| deleteAudio(audios); | ||
| const didItDelete = await getInfoAsync(audios); |
yarn.lock
Outdated
There was a problem hiding this comment.
we should not have yarn; only use npm
App.tsx
Outdated
| import RootNavigation from './src/navigation/RootNavigator'; | ||
| // import QueriesDemo from './src/firebase/QueriesDemo'; |
There was a problem hiding this comment.
these should be removed
App.tsx
Outdated
| await SplashScreen.hideAsync(); | ||
| } | ||
| }, [resourcesLoaded]); | ||
|
|
||
| return !resourcesLoaded ? null : ( | ||
| <View style={styles.container} onLayout={onLayoutRootView}> | ||
| {/* <AudioDemos /> */} |
src/firebase/AudioDemos.tsx
Outdated
| console.log(didItDelete); | ||
| }; | ||
|
|
||
| // useEffect(() => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 What's new in this PR 🎉
Audio can now be downloaded to Expo File System and deleted from the File System.
☁️ ☁️ Description ☁️ ☁️
With the audio ID, audio will be downloaded from Firebase into the Expo File System. We have also implemented a delete function that will delete the audio from the File System using the deleteAsync function that takes in the Audio's ID that needs to be deleted.
Screenshots 📲
⚡ How to review ⚡
We tested this by integrating Audio Demo into the play screen. There, you can input any valid audio ID from cs-firebase and on terminal you should get log info messages that let you know if the audio exists in FileSystema and if its deleted. We set it up so that after an ID is inputted, it will get downloaded and then immediately deleted. These should be console logged to terminal to show if it exists or not.
🌱 Next steps 🌱
Relevant Links 🔗
Expo File System Documentation: https://docs.expo.dev/versions/latest/sdk/filesystem/#saf-uri
Online sources ℹ️
Related PRs 🙌
CC: @davidqing6432